Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinghy: 1.3.0 -> 1.3.2; fix build #266206

Merged
merged 1 commit into from Nov 8, 2023
Merged

dinghy: 1.3.0 -> 1.3.2; fix build #266206

merged 1 commit into from Nov 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2023

Description of changes

ZHF: #265948
https://hydra.nixos.org/build/239123155

migrate to pyproject as there is no setup.py

https://github.com/nedbat/dinghy/releases/tag/1.3.2
https://github.com/nedbat/dinghy/releases/tag/1.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2023
@ghost
Copy link
Author

ghost commented Nov 8, 2023

Result of nixpkgs-review pr 266206 run on x86_64-linux 1

4 packages built:
  • dinghy (python311Packages.dinghy)
  • dinghy.dist (python311Packages.dinghy.dist)
  • python310Packages.dinghy
  • python310Packages.dinghy.dist

@wamserma
Copy link
Member

wamserma commented Nov 8, 2023

Result of nixpkgs-review pr 266206 run on aarch64-linux 1

4 packages built:
  • dinghy (python311Packages.dinghy)
  • dinghy.dist (python311Packages.dinghy.dist)
  • python310Packages.dinghy
  • python310Packages.dinghy.dist

Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2023
@natsukium
Copy link
Member

Result of nixpkgs-review pr 266206 at 1f1d46d run on aarch64-darwin 1

2 packages built successfully:
  • dinghy (python311Packages.dinghy)
  • python310Packages.dinghy

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit eb2f8aa into NixOS:master Nov 8, 2023
17 of 18 checks passed
@ghost ghost deleted the dinghy branch November 8, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants