newlib: fix newlib host/target workaround #266364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2023
ghost
added
the
0.kind: ZHF Fixes
ghost
marked this pull request as ready for review
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ghost
marked this pull request as draft
ofborg
bot
added
10.rebuild-darwin: 0
added 2 commits
November 8, 2023 17:48
The newlib configury uses `host` to refer to the platform which is being used to compile newlib. Ugh. It does this because of its history: newlib used to be distributed with and built as part of gcc. To prevent nixpkgs from going insane, this package presents the "normal" view to the outside world: the binaries in $out will execute on `stdenv.hostPlatform`. We then fool newlib's build process into doing the right thing.
ghost
marked this pull request as ready for review
pbsds
approved these changes
Nov 12, 2023
delroth
added
the
12.approvals: 1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the failing Hydra builds for newlib.x86_64-linux
Description of changes
The newlib configury uses
hostto refer to the platform which isbeing used to compile newlib. Ugh. It does this because of its
history: newlib used to be distributed with and built as part of
gcc.
To prevent nixpkgs from going insane, this package presents the
"normal" view to the outside world: the binaries in $out will
execute on
stdenv.hostPlatform. We then fool newlib's buildprocess into doing the right thing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)