Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prayer: remove #266532

Merged
merged 1 commit into from
Nov 10, 2023
Merged

prayer: remove #266532

merged 1 commit into from
Nov 10, 2023

Conversation

tu-maurice
Copy link
Contributor

@tu-maurice tu-maurice commented Nov 9, 2023

Description of changes

This PR removes anything related to the prayer package. For this I present the following reasons:

  • The package has not been touched in almost 4 years.
  • It failed to build in the past 2 years, which means no active users.
  • The sources are not available anymore, so we're only relying on hydras cache for this.
  • Fixing the build doesn't get the derivation into a clean nor usable state. See prayer: use html-tidy 5.6 #266129

I think this package is beyond a point where marking it as broken is reasonable, because "Such unconditionally-broken packages should be removed from Nixpkgs eventually unless they are fixed." (quote Nixpkgs manual) and the package is beyond fixing.

I should probably add some error message somewhere, explaining that the packages is gone, but I have no idea how or where. Any thoughts?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 9, 2023
@tu-maurice tu-maurice mentioned this pull request Nov 9, 2023
13 tasks
@ambroisie
Copy link
Contributor

The place to add a message about removed packages is in aliases.nix, you should find plenty of examples in the file.

@tu-maurice tu-maurice force-pushed the upstream/remove-prayer branch from 09e3dde to 684c08f Compare November 9, 2023 22:19
@tu-maurice
Copy link
Contributor Author

tu-maurice commented Nov 9, 2023

Neat. Is there a similar spot for the module? Or do I just remove that?

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 9, 2023
@ambroisie
Copy link
Contributor

NixOS modules have rename.nix I believe (can't check as I'm on mobile).

@tu-maurice tu-maurice force-pushed the upstream/remove-prayer branch from 684c08f to 26afb88 Compare November 9, 2023 22:31
@tu-maurice
Copy link
Contributor Author

Ah. Yeah there's one with plenty examples. Thank you, @ambroisie :)

@pbsds
Copy link
Member

pbsds commented Nov 9, 2023

I think removal of service modules should go in the release notes.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 9, 2023
@tu-maurice tu-maurice force-pushed the upstream/remove-prayer branch from 26afb88 to 2a01eb3 Compare November 10, 2023 09:52
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 10, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 10, 2023
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

nixos/modules/misc/ids.nix Show resolved Hide resolved
nixos/modules/misc/ids.nix Show resolved Hide resolved
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 10, 2023
@tu-maurice tu-maurice force-pushed the upstream/remove-prayer branch from 2a01eb3 to 65f8f07 Compare November 10, 2023 20:42
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 10, 2023
@AndersonTorres
Copy link
Member

A prayer for the removal of prayer.

@AndersonTorres AndersonTorres merged commit 40c06a1 into NixOS:master Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants