-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prayer: remove #266532
prayer: remove #266532
Conversation
The place to add a message about removed packages is in |
09e3dde
to
684c08f
Compare
Neat. Is there a similar spot for the module? Or do I just remove that? |
NixOS modules have |
684c08f
to
26afb88
Compare
Ah. Yeah there's one with plenty examples. Thank you, @ambroisie :) |
I think removal of service modules should go in the release notes. |
26afb88
to
2a01eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit
2a01eb3
to
65f8f07
Compare
A prayer for the removal of prayer. |
Description of changes
This PR removes anything related to the prayer package. For this I present the following reasons:
I think this package is beyond a point where marking it as broken is reasonable, because "Such unconditionally-broken packages should be removed from Nixpkgs eventually unless they are fixed." (quote Nixpkgs manual) and the package is beyond fixing.
I should probably add some error message somewhere, explaining that the packages is gone, but I have no idea how or where. Any thoughts?
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)