Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctranslate2: 3.20.0 -> 3.21.0 #266731

Merged
merged 1 commit into from
Nov 11, 2023
Merged

ctranslate2: 3.20.0 -> 3.21.0 #266731

merged 1 commit into from
Nov 11, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 10, 2023 •
edited
Loading

https://github.com/OpenNMT/CTranslate2/blob/v3.21.0/CHANGELOG.md

Description of changes

/nix/store/jwfc9vv8kryfs9bz4jzwn8f15qrhk2v5-python3.11-libretranslate-1.3.11
/nix/store/vlzs5ggapb8hkirlg11y5rlnjvmy72ls-wyoming-faster-whisper-1.0.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from misuzu November 10, 2023 22:29
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 10, 2023
@natsukium
Copy link
Member

natsukium commented Nov 11, 2023 •
edited
Loading

Result of nixpkgs-review pr 266731 at dcfd1e8 run on aarch64-darwin 1

15 packages marked as broken and skipped:
  • libretranslate
  • python310Packages.argos-translate-files
  • python310Packages.argostranslate
  • python310Packages.ctranslate2
  • python310Packages.faster-whisper
  • python310Packages.libretranslate
  • python310Packages.translatehtml
  • python311Packages.argos-translate-files
  • python311Packages.argostranslate
  • python311Packages.ctranslate2
  • python311Packages.faster-whisper
  • python311Packages.libretranslate
  • python311Packages.translatehtml
  • whisper-ctranslate2
  • wyoming-faster-whisper

Result of nixpkgs-review pr 266731 at dcfd1e8 run on x86_64-linux 1

14 packages failed to build:
  • libretranslate (python311Packages.libretranslate)
  • python310Packages.argos-translate-files
  • python310Packages.argostranslate
  • python310Packages.ctranslate2
  • python310Packages.faster-whisper
  • python310Packages.libretranslate
  • python310Packages.translatehtml
  • python311Packages.argos-translate-files
  • python311Packages.argostranslate
  • python311Packages.ctranslate2
  • python311Packages.faster-whisper
  • python311Packages.translatehtml
  • whisper-ctranslate2
  • wyoming-faster-whisper
1 package built successfully:
  • ctranslate2

misuzu
misuzu approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@misuzu misuzu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running libretranslate. jaxlib is broken on master

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 11, 2023
@mweinelt
Copy link
Member Author

jaxlib is broken on master

Bisected to #265041

@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 266731 run on x86_64-linux 1

29 packages built:
  • ctranslate2
  • libretranslate (python311Packages.libretranslate)
  • libretranslate.dist (python311Packages.libretranslate.dist)
  • python310Packages.argos-translate-files
  • python310Packages.argos-translate-files.dist
  • python310Packages.argostranslate
  • python310Packages.argostranslate.dist
  • python310Packages.ctranslate2
  • python310Packages.ctranslate2.dist
  • python310Packages.faster-whisper
  • python310Packages.faster-whisper.dist
  • python310Packages.libretranslate
  • python310Packages.libretranslate.dist
  • python310Packages.translatehtml
  • python310Packages.translatehtml.dist
  • python311Packages.argos-translate-files
  • python311Packages.argos-translate-files.dist
  • python311Packages.argostranslate
  • python311Packages.argostranslate.dist
  • python311Packages.ctranslate2
  • python311Packages.ctranslate2.dist
  • python311Packages.faster-whisper
  • python311Packages.faster-whisper.dist
  • python311Packages.translatehtml
  • python311Packages.translatehtml.dist
  • whisper-ctranslate2
  • whisper-ctranslate2.dist
  • wyoming-faster-whisper
  • wyoming-faster-whisper.dist

@mweinelt mweinelt merged commit adf69b2 into NixOS:master Nov 11, 2023
14 of 15 checks passed
@mweinelt mweinelt deleted the ctranslate2-3.21.0 branch November 11, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mweinelt @natsukium @misuzu @delroth