osl: fix build, 1.12.13.0 -> 1.12.14.0 #268670
Conversation
| @@ -52,15 +52,15 @@ in stdenv.mkDerivation rec { | |||
|
|
|||
| nativeBuildInputs = [ | |||
| bison | |||
| clang | |||
| clang_15 | |||
There was a problem hiding this comment.
not going going to block this PR, is there an upstream issue/PR to track clang 16 support ?
There was a problem hiding this comment.
I wasn't able to find one, but I could open one if that makes things simpler to track
There was a problem hiding this comment.
Actually, not sure how I missed it, but there is this: AcademySoftwareFoundation/OpenShadingLanguage#1730
Unfortunately, applying the PR directly fails, but I guess it will be in one of the next releases.
|
segfault on darwin. I assume it used to build on darwin because of optional depndency on libxml2 |
|
Hmm, I don't really know how they work or what they're supposed to do, but the binaries seem to work for me on linux with some test files from the repo, or at least they don't crash. I don't have a darwin system to test on, and the maintainer doesn't look to have been active in a while. Maybe @wegank who has added it can take a look? |
lets wait at least a few more days, after that, we can just disable darwin |
|
I'll push a fix. |
|
ZHF #265948 |
pbsds
added
0.kind: ZHF Fixes
|
Result of 1 package built:
LGTM, thanks! |
|
Successfully created backport PR for |
Description of changes
Fixes #262633
Changelog is here
Fixed llvm version to 15 because it otherwise fails with an error that 16 is not supported.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Pinging maintainers @Hodapp87