Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vesktop: add cacert to pnpmDeps derivation #268758

Merged
merged 1 commit into from
Nov 21, 2023
Merged

vesktop: add cacert to pnpmDeps derivation #268758

merged 1 commit into from
Nov 21, 2023

Conversation

Scrumplex
Copy link
Member

Description of changes

Closes #268517

Caused by #257513

ZHF #265948

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Scrumplex Scrumplex added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 20, 2023
@Scrumplex
Copy link
Member Author

CC @gilligan @marsam @cillianderoiste @cko

Is this the intended fix for fixed output derivations that use nodejs?

@Scrumplex Scrumplex mentioned this pull request Nov 20, 2023
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 20, 2023
@Scrumplex Scrumplex requested review from getchoo, vgskye and pluiedev and removed request for getchoo November 20, 2023 22:38
vgskye
vgskye approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@vgskye vgskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might've had a feeling this would have been the fix

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 20, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 21, 2023
@Scrumplex Scrumplex added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package needs_merger (old Marvin label, do not use) labels Nov 21, 2023
PedroHLC
PedroHLC approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fixes mentioned building error
  • Builds to /nix/store/p5srv8z3lx9ccr3jqn79n4z7s2aqv99c-vesktop-0.4.3 successfully
  • Runs:
    image

@PedroHLC PedroHLC added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 21, 2023
@thiagokokada thiagokokada merged commit 017e558 into NixOS:master Nov 21, 2023
17 checks passed
@Scrumplex Scrumplex deleted the pkgs/vesktop/cacert-pnpm branch September 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgskye vgskye vgskye approved these changes

@pluiedev pluiedev pluiedev approved these changes

@PedroHLC PedroHLC PedroHLC approved these changes

@getchoo getchoo Awaiting requested review from getchoo

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package needs_merger (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: vesktop-pnpm-deps
6 participants
@Scrumplex @PedroHLC @pluiedev @vgskye @delroth @thiagokokada