Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tectonic: fixes #269167: tectonic build failure #269786

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ink-splatters
Copy link
Contributor

This workaround is inspired by similar fix: b6d4be1

Root cause: Some libc++abi symbols are missing with LLVM12+'s stdenv on Darwin (#166205)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 25, 2023
@ink-splatters ink-splatters marked this pull request as ready for review November 25, 2023 04:43
@ofborg ofborg bot requested review from lluchs and doronbehar November 25, 2023 05:56
@kirillrdy
Copy link
Member

@ink-splatters greetings !

thank you for your contribution. Can you please update commit message and PR title to match contribution guidelines.

This is done so that CI can run automated tests for appropriate packages.

implements workaround for: NixOS#166205

inspired by similar fix: NixOS@b6d4be1
@ink-splatters ink-splatters changed the title Fixes #269167: tectonic build failure tectonic: fixes #269167: tectonic build failure Nov 25, 2023
@ink-splatters
Copy link
Contributor Author

@kirillrdy hope it's fine now, otherwise please let me know!

Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 26, 2023
@pbsds
Copy link
Member

pbsds commented Nov 27, 2023

@pbsds pbsds merged commit 2816853 into NixOS:master Nov 27, 2023
13 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants