libserdes: link with libc++ libc++abi; fix darwin build #270605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
0.kind: ZHF Fixes
ghost
requested a review
from 
|
Result of
|
liff
reviewed
Nov 28, 2023
this is expected as this has no effect for the x64 linux derivation. i neglected to mention darwin in the PR title, fixed. |
ghost
changed the title
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
liff
approved these changes
Nov 28, 2023
when stdenv.cc.libcxx is non null update the libserdes++ libs from libstd++ to libc++ libc++abi. This fixes the link error on darwin. However, on x64 linux using stdenv = llvmPackages_16.libcxxStdenv on linux the build fails unless -std=c++11 or above is used. testing; built. the only program that depends on libserdes, kcat, links to the libserdes and not libserdes++.
liff
approved these changes
Nov 28, 2023
delroth
added
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1267 |
|
Successfully created backport PR for |
1 task
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when stdenv.cc.libcxx is non null update the libserdes++ libs from libstd++ to libc++ libc++abi. This fixes the link error on darwin. However, on x64 linux using stdenv = llvmPackages_16.libcxxStdenv on linux the build fails unless -std=c++11 or above is used.
testing; built. the only program that depends on libserdes, kcat, links to the libserdes and not libserdes++.
ZHF: #265948
https://hydra.nixos.org/build/241150556
Result of
nixpkgs-reviewrun on x86_64-darwin 13 packages built:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Priorities
Add a 👍 reaction to pull requests you find important.