Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httptunnel: update to latest rev; fix darwin #270625

Merged
merged 1 commit into from Nov 29, 2023
Merged

httptunnel: update to latest rev; fix darwin #270625

merged 1 commit into from Nov 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2023

version in nixpkgs is at least older than 2012
larsbrinkhoff/httptunnel@3b2a6f1...d8f91af

build was broken because the configure script was producing code that clang deemed invalid. updating to the latest revision fixes the build.

ZHF: #265948
https://hydra.nixos.org/build/241221754
Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • httptunnel

Result of nixpkgs-review run on x86_64-darwin 1

1 package built:
  • httptunnel

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@ghost ghost added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-23.11 labels Nov 28, 2023
@ghost
Copy link
Author

ghost commented Nov 28, 2023

cc maintainer: @k0ral

@k0ral
Copy link
Contributor

k0ral commented Nov 28, 2023

Looks good to me 🙂 .

@emilytrau emilytrau merged commit 1868b85 into NixOS:master Nov 29, 2023
18 of 19 checks passed
Copy link
Contributor

Successfully created backport PR for release-23.11:

@ghost
Copy link
Author

ghost commented Nov 29, 2023

thanks!

@ghost ghost deleted the httptunnel branch November 29, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants