cc-wrapper: Resolve mktemp and rm path statically #271339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts cc-wrapper.sh into a .nix file consisting of one large string. This will allow future commits to hoist conditionals out of bash code, into Nix code. This allows to add or remove conditional code from the cc-wrapper **without causing rebuilds on platforms where the condition is false**.
ghost
marked this pull request as ready for review
This was referenced Dec 1, 2023
Without this, mktemp (and rm) from the host environment is picked up. This may result in mktemp behaving differently (on darwin) or mktemp / rm not being found at all. Adapted from: 77c5993 Co-Authored-By: Malte Poll <[email protected]>
ofborg
bot
added
10.rebuild-darwin-stdenv
ghost
closed this
|
Was this closed in favor of another PR or merged in another way? If not, may I ask why this was closed? As I understand it this change would resolve the issue that #271159 aimed to resolve, see also #258607 (comment) for another relevant thread. I recently encountered the same issue when running a Nix provided GHC in a restricted environment on MacOS. In that case cc @avdv |
|
@aherrmann @malt3 I think the closing of this PR happened in in the light of #50105 (comment). Maybe you can cherry-pick and open a new PR or wait some days until things have calmed a little. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adaptation of
Based on (and includes)