Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notejot: fix build with newer vala #271543

Closed
wants to merge 1 commit into from
Closed

notejot: fix build with newer vala #271543

wants to merge 1 commit into from

Conversation

arthsmn
Copy link
Member

@arthsmn arthsmn commented Dec 1, 2023 •
edited
Loading

Description of changes

Added a patch that fix compilation with newer vala.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@arthsmn arthsmn changed the title notejot: fix build with new vala notejot: fix build with newer vala Dec 1, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3026

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 2, 2023
@ofborg ofborg bot requested a review from AndersonTorres December 2, 2023 08:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 2, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 2, 2023
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 2, 2023
@delroth delroth added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 2, 2023
@AndersonTorres
Copy link
Member

Try a rebase

@arthsmn arthsmn closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arthsmn @nixos-discourse @AndersonTorres @SuperSandro2000 @delroth