-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocmPackages_5: pin stdenv to GCC 12 #271954
Conversation
@amjoseph-nixpkgs can we just cherry-pick this into your PR? |
Testing now... |
Could you switch the base branch to Once my build finishes I'll merge this and rebase #268097 |
Thanks, I got build failures in The second commit in that PR might not be necessary; checking that right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 99% of the solution; the other 1% is in
Will merge as soon as ofborg finishes CI. |
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Try reverting this on a future ROCm release. Addresses: NixOS#271943
Rebased in order to make ofborg re-eval. |
I have built both of these derivations locally:
The first derivation is the one that @ofborg choked on. The second derivation is Therefore, I am going to merge this. Good thing we can run CT locally! |
Description of changes
Lazy fix for the linked issue that I have not tested, as I do not have much time currently.
Only merge once #268097 is merged.
There is a lot more I can do here, there was a
rocmPackages
rework I was working on,which I think I accidentally just killed with this branchthankfully github is smart (https://github.com/Madouura/nixpkgs/tree/dev/rocm-rework). Oh well. Any further improvements/nitpicks should go to that, this is just a quick fix.Fixes: #271943
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.