Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staging-next 2023-12-20 #275620

Merged
merged 1,603 commits into from
Jan 12, 2024
Merged

staging-next 2023-12-20 #275620

merged 1,603 commits into from
Jan 12, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Dec 20, 2023

@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 20, 2023
@vcunat vcunat requested a review from a user December 20, 2023 11:12
@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation labels Dec 20, 2023
vcunat and others added 13 commits January 11, 2024 10:01
T055-path-config.sh seems to have gotten broken by
9b42592, for unknown reasons.

It's used in sphinxcontrib-apidoc, but even a sphinx without the module
is not sufficient to get the testsuite to pass again.

There's another reference through it via libtiff, which is fairly deep
in the build graph (even before systemd), so until that's disentangled,
the least intrusive way to get the builds to succeed is skipping this
test.

When trying to validate this, I very frequently ran into another test
failure in T460-emacs-tree, so I removed that one too.

As for the notmuch2 matter, I checked a downstream consumer of
python3.pkgs.notmuch2 (alot) still works.
I forgot to commit a part of the change :-/
@vcunat vcunat requested a review from tfc as a code owner January 12, 2024 10:58
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 12, 2024
@vcunat vcunat merged commit bae093a into master Jan 12, 2024
14 checks passed
@imincik imincik mentioned this pull request Jan 15, 2024
13 tasks
@yisraeldov
Copy link
Contributor

Hello @vcunat This merge breaks libresprite build

found with

git bisect start  --first-parent origin/master b0db08979c620fc3b774fdda88db0943d723eb59
git bisect run nix-build -A libresprite `pwd`

@K900
Copy link
Contributor

K900 commented Jan 18, 2024

This is to some extent expected. Staging merges will always cause some amount of regressions, as it's impossible to address every single one in a reasonable timeframe.

@yisraeldov
Copy link
Contributor

Thanks, so what is the right way to report this so it doesn't get forgotten?

@K900
Copy link
Contributor

K900 commented Jan 18, 2024

Fixed: #281732

Please test.

@yisraeldov
Copy link
Contributor

Fixed: #281732

Please test.

Works #:+1:

Thank you.

@K900 you are a scholar and a gentleman

imincik added a commit to imincik/geospatial-nix that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: emacs Text editor 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: systemd 6.topic: TeX Issues regarding texlive and TeX in general 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.