Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comet-gog: init at 0-unstable-2024-05-25 #278800

Merged
merged 1 commit into from
Jun 6, 2024
Merged

comet-gog: init at 0-unstable-2024-05-25 #278800

merged 1 commit into from
Jun 6, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jan 5, 2024 •
edited
Loading

Description of changes

Closes #278554

This PR adds 1 package: comet-gog

There is no proper versioning as of creating this PR, so the latest commit was used here.

I haven't been able to check if it actually works in action.
@EthanHarp as the creator of the package request, could you possible check if it works?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

GetPsyched
GetPsyched reviewed Jan 6, 2024
View reviewed changes
Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just some minor nits

pkgs/by-name/co/comet/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/comet/package.nix Outdated Show resolved Hide resolved
@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jan 6, 2024

Just a thought: maybe comet is too general of a name, maybe it should be something like comet-gog or something to not confuse it with other projects with a similar name.

Repology link: https://repology.org/projects/?search=comet
(comet comet-git comet-ms and python:comet are all different from this)

@GetPsyched
Copy link
Member

Feel free to do so. comet-gog sounds good to me.

@TomaSajt TomaSajt changed the title comet: init at unstable-2023-12-09 comet-gog: init at unstable-2023-12-09 Jan 6, 2024
@GetPsyched GetPsyched added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 6, 2024
@GetPsyched
Copy link
Member

Result of nixpkgs-review pr 278800 run on x86_64-linux 1

2 packages built:
  • comet-gog
  • comet-gog.dist

@TomaSajt TomaSajt changed the title comet-gog: init at unstable-2023-12-09 comet-gog: init at 0-unstable-2024-03-28 Mar 31, 2024
@TomaSajt
Copy link
Contributor Author

Looks like the project got "Rewrite in Rust" treatment.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 2, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/rust-package-doesnt-want-to-build-protoc-binary-not-found/42365/4

@TomaSajt TomaSajt force-pushed the comet branch 2 times, most recently from 6125135 to bd6517a Compare May 2, 2024 19:31
@TomaSajt TomaSajt changed the title comet-gog: init at 0-unstable-2024-03-28 comet-gog: init at 0-unstable-2024-04-26 May 2, 2024
@pbsds
Copy link
Member

pbsds commented Jun 5, 2024

can you mark the failing platforms as meta.broken?

@TomaSajt TomaSajt force-pushed the comet branch 2 times, most recently from e4fb324 to f0932de Compare June 6, 2024 06:37
@TomaSajt TomaSajt changed the title comet-gog: init at 0-unstable-2024-04-26 comet-gog: init at 0-unstable-2024-05-25 Jun 6, 2024
@TomaSajt TomaSajt force-pushed the comet branch 2 times, most recently from b422ee2 to 83adb20 Compare June 6, 2024 09:22
@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jun 6, 2024

@ofborg build comet-gog

@pbsds pbsds merged commit 1de06ca into NixOS:master Jun 6, 2024
23 of 24 checks passed
@emilazy emilazy mentioned this pull request Aug 25, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Aug 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GetPsyched GetPsyched GetPsyched approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Comet
6 participants
@TomaSajt @GetPsyched @nixos-discourse @pbsds @wegank @emilazy