zed-editor: init at 0.129.1 #284010

GaetanLepage · 2024-01-26T12:48:33Z

Description of changes

Add zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

Things done

Add a 👍 reaction to pull requests you find important.

wegank

zed -> zed-editor in the commit message and the title.

PaulGrandperrin · 2024-01-26T14:59:44Z

Hi,
I just tried building on nixos-23.11 and I get a build failure:

error: failed to run custom build command for `gpui v0.1.0 (/build/source/crates/gpui)`

Caused by:
  process didn't exit successfully: `/build/source/target/release/build/gpui-18ab4c5689d6bc1b/build-script-build` (exit status: 101)
  --- stdout
  cargo:rustc-link-lib=framework=System
  cargo:rerun-if-changed=src/platform/mac/dispatch.h
  cargo:rerun-if-env-changed=TARGET
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS

  --- stderr
  src/platform/mac/dispatch.h:1:10: fatal error: 'dispatch/dispatch.h' file not found
  thread 'main' panicked at crates/gpui/build.rs:31:10:
  unable to generate bindings: ClangDiagnostic("src/platform/mac/dispatch.h:1:10: fatal error: 'dispatch/dispatch.h' file not found\n")
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

pkgs/by-name/ze/zed-editor/package.nix

Resolved

NickCao · 2024-01-26T15:00:58Z

Hi, I just tried building on nixos-23.11 and I get a build failure:

It only supports darwin, not linux, for now.

PaulGrandperrin · 2024-01-26T15:15:10Z

Hi, I just tried building on nixos-23.11 and I get a build failure:

It only supports darwin, not linux, for now.

Oh 🥲
Yeah i didn't check upstream project..

GaetanLepage · 2024-01-26T15:20:45Z

Building fails when compiling the media crate (here on aarch64-darwin):

error: failed to run custom build command for `media v0.1.0 (/private/tmp/nix-build-zed-0.119.19.drv-0/source/crates/media)`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-zed-0.119.19.drv-0/source/target/release/build/media-0b943f1fb28af98c/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=src/bindings.h
  cargo:rerun-if-env-changed=TARGET
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64-apple-darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS_aarch64_apple_darwin
  cargo:rerun-if-env-changed=BINDGEN_EXTRA_CLANG_ARGS

  --- stderr
  src/bindings.h:1:9: fatal error: 'CoreMedia/CMFormatDescription.h' file not found
  thread 'main' panicked at crates/media/build.rs:33:10:
  unable to generate bindings: ClangDiagnostic("src/bindings.h:1:9: fatal error: 'CoreMedia/CMFormatDescription.h' file not found\n")
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

wegank · 2024-01-27T02:51:34Z

Probably add CoreMedia and try again?

GaetanLepage · 2024-01-27T13:05:08Z

Probably add CoreMedia and try again?

Indeed that helped !

It now fails with:

cargo:rerun-if-changed=./src/platform/mac/shaders.metal

--- stderr
Failed to run rustfmt: cannot find binary path (non-fatal, continuing)
metal shader compilation failed:
/nix/store/c70whv4m822qpi47pfdrclx0q9i4dcnf-xcrun/bin/xcrun: line 42: exec: metal: not found

It looks like darwin.apple_dsk.frameworks.Metal does not provide the requested metal binary.

jansol · 2024-04-03T21:22:44Z

@GaetanLepage did nix-update "helpfully" eat my suggested changes or did you just not get to applying them yet?

GaetanLepage · 2024-04-03T22:03:32Z

@GaetanLepage did nix-update "helpfully" eat my suggested changes or did you just not get to applying them yet?

No, I just didn't have done it yet.

I did include both changes now (fontconfig + desktop file).
However it still does not build:

...
   Compiling activity_indicator v0.1.0 (/build/source/crates/activity_indicator)
   Compiling quick_action_bar v0.1.0 (/build/source/crates/quick_action_bar)
   Compiling welcome v0.1.0 (/build/source/crates/welcome)
    Finished release [optimized + debuginfo] target(s) in 5m 56s
     Running unittests src/main.rs (target/x86_64-unknown-linux-gnu/release/deps/Zed-9da96fb920105d52)

running 4 tests
error: test failed, to rerun pass `--bin Zed`

Caused by:
  process didn't exit successfully: `/build/source/target/x86_64-unknown-linux-gnu/release/deps/Zed-9da96fb920105d52 --test-threads=48 --skip=test_base_keymap --skip=test_bundled_settings_and_themes --skip=test_disabled_keymap_binding --skip=test_navigation --skip=test_new_empty_workspace --skip=test_open_and_save_new_file --skip=test_open_entry --skip=test_opening_excluded_paths --skip=test_open_paths --skip=test_open_paths_action --skip=test_pane_actions --skip=test_reopening_closed_items --skip=test_save_conflicting_item --skip=test_setting_language_when_saving_as_single_file_worktree --skip=test_window_edit_state` (signal: 11, SIGSEGV: invalid memory reference)

jansol · 2024-04-03T22:39:38Z

Looks like you grabbed the original version of the desktop item snippet, which hardcodes the full executable path and is missing the "inode/directory" mime type rather than the fixed version. Nevertheless, the build passes fine on my end:

$ nix build github:GaetanLepage/nixpkgs/zed#zed-editor
$ tree result
result
├── bin
│   ├── zed -> zed-stable
│   └── zed-stable
└── share
    ├── applications
    │   └── Zed.desktop
    └── icons
        └── hicolor
            ├── 1024x1024@2x
            │   └── apps
            │       └── Zed.png
            └── 512x512
                └── apps
                    └── Zed.png

GaetanLepage · 2024-04-04T08:08:04Z

ooks like you grabbed the original version of the desktop item snippet, which hardcodes the full executable path and is missing the "inode/directory" mime type rather than the fixed version.

You are right ! Fixed.

jansol · 2024-04-04T09:10:26Z

Did you get the tests to pass on your side?

Tried with Nix on Ubuntu 24.04 now and it builds fine, but crashes on launch due to vulkan driver stuff (with both X11 and Wayland backends). Given that it works fine on NixOS I don't consider this a blocker though (assuming darwin is fine).

pkgs/by-name/ze/zed-editor/package.nix

SuperSandro2000 · 2024-04-04T09:30:40Z

Tried with Nix on Ubuntu 24.04 now and it builds fine, but crashes on launch due to vulkan driver stuff (with both X11 and Wayland backends). Given that it works fine on NixOS I don't consider this a blocker though (assuming darwin is fine).

This is a common problem, you probably can work around this with nixGL

Titaniumtown · 2024-04-08T03:53:17Z

Hey sorry for this newbie comment. I'm pretty new to nixos, how can I add this to my home manager flake? I spent an hour or so trying to figure it out and read a bunch online, can someone give some pointers? I want to try and test/use zed-editor on my machine.

wyndon · 2024-04-08T04:03:34Z

Hey sorry for this newbie comment. I'm pretty new to nixos, how can I add this to my home manager flake? I spent an hour or so trying to figure it out and read a bunch online, can someone give some pointers? I want to try and test/use zed-editor on my machine.

If you just want to try it, you can run nix run github:NixOS/nixpkgs/pull/284010/head#zed-editor

If you want to add it to your configuration, add github:NixOS/nixpkgs/pull/284010/head as an input, make sure inputs are passed in extraSpecialArgs and add it to home.packages with inputs.INPUTNAME.legacyPackages.${pkgs.system}.zed-editor

Titaniumtown · 2024-04-08T04:05:34Z

@wyndon thank you so much! you're amazing <3

GaetanLepage · 2024-04-08T13:39:55Z

Thanks @SuperSandro2000 for the review and merge :)
And thank you @jansol for all your help !

LeonardAukea · 2024-04-09T08:10:35Z

Should this package not be visible at https://search.nixos.org/packages now that it has been merged to master?

GaetanLepage · 2024-04-09T08:12:59Z

Should this package not be visible at https://search.nixos.org/packages now that it has been merged to master?

No, there is a delay between master and nixos-unstable. You can follow the progress of this PR here.

bnjmnt4n · 2024-04-09T08:13:12Z

It typically takes some time to land from master to other channels; you can look at https://nixpk.gs/pr-tracker.html?pr=284010 to see if it's landed.

(😆 looks like we made the same comment at around the same time)

LeonardAukea · 2024-04-09T08:21:40Z

Should this package not be visible at https://search.nixos.org/packages now that it has been merged to master?

No, there is a delay between master and nixos-unstable. You can follow the progress of this PR here.

Thanks for the info 🙏 I was not aware of the PR tracker. I suspected that there would be some sort of delay but 20h seemed rather long.

jansol · 2024-04-09T09:07:42Z

I suspected that there would be some sort of delay but 20h seemed rather long.

You can also peek at https://status.nixos.org to see when your release channel last got updated. There can easily be a few days of delay if CI is failing.

musjj · 2024-04-09T09:27:38Z

I suspected that there would be some sort of delay but 20h

It normally takes roughly ~3 days unfortunately, and that's an optimistic estimate. I really do wish something can be done about it, it would be disastrous the next time something like xz actually hits NixOS.

SuperSandro2000 · 2024-04-09T09:34:31Z

I've locked the conversation to stop the general off topic chat in this PR as every comment pings 20 plus people.

It normally takes roughly ~3 days unfortunately, and that's an optimistic estimate.

It really depends on the changes that are going through and if there are regressions it takes a bit longer but we are generally really fast in the last months.

I really do wish something can be done about it, it would be disastrous the next time something like xz actually hits NixOS.

xz is a totally separate issue as this is part of the bootstrapping and updating those packages takes way longer because, well it is the bootstrapping.

GaetanLepage requested review from lilyinstarlight, wegank and NickCao January 26, 2024 12:48

GaetanLepage force-pushed the zed branch 2 times, most recently from 1db7ca8 to 168dedb Compare January 26, 2024 12:49

wegank previously requested changes Jan 26, 2024

View reviewed changes

GaetanLepage changed the title ~~zed: init at 0.119.19~~ zed-editor: init at 0.119.19 Jan 26, 2024

GaetanLepage force-pushed the zed branch 2 times, most recently from 98a9f55 to fcac468 Compare January 26, 2024 13:40

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 26, 2024

wegank reviewed Jan 26, 2024

View reviewed changes

pkgs/by-name/ze/zed-editor/package.nix Outdated Show resolved Hide resolved

GaetanLepage force-pushed the zed branch from fcac468 to 136d217 Compare January 26, 2024 15:19

ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 26, 2024

domenkozar mentioned this pull request Jan 26, 2024

publish zed to nixos package registry zed-industries/zed#4252

Closed

jtbx mentioned this pull request Jan 26, 2024

Package request: Code-Editor Zed #284064

Closed

GaetanLepage force-pushed the zed branch from 136d217 to 55b08e9 Compare January 27, 2024 13:04

GaetanLepage force-pushed the zed branch from 43ae675 to 2ab5834 Compare April 3, 2024 19:44

GaetanLepage changed the title ~~zed-editor: init at 0.128.3~~ zed-editor: init at 0.129.1 Apr 3, 2024

GaetanLepage force-pushed the zed branch from 2ab5834 to 2b2828d Compare April 3, 2024 21:58

GaetanLepage force-pushed the zed branch 2 times, most recently from 5c629c5 to 084eea8 Compare April 4, 2024 08:07

SuperSandro2000 reviewed Apr 4, 2024

View reviewed changes

GaetanLepage force-pushed the zed branch 2 times, most recently from bcc3f47 to eb2b2fc Compare April 4, 2024 13:05

zed-editor: init at 0.129.2

1dc8a2c

GaetanLepage force-pushed the zed branch from eb2b2fc to 1dc8a2c Compare April 4, 2024 13:54

SuperSandro2000 merged commit c011096 into NixOS:master Apr 8, 2024
24 checks passed

GaetanLepage deleted the zed branch April 8, 2024 13:39

NixOS locked as off-topic and limited conversation to collaborators Apr 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zed-editor: init at 0.129.1 #284010

zed-editor: init at 0.129.1 #284010

GaetanLepage commented Jan 26, 2024 •

edited

Loading

wegank left a comment

PaulGrandperrin commented Jan 26, 2024

NickCao commented Jan 26, 2024

PaulGrandperrin commented Jan 26, 2024

GaetanLepage commented Jan 26, 2024 •

edited

Loading

wegank commented Jan 27, 2024

GaetanLepage commented Jan 27, 2024

jansol commented Apr 3, 2024

GaetanLepage commented Apr 3, 2024

jansol commented Apr 3, 2024 •

edited

Loading

GaetanLepage commented Apr 4, 2024

jansol commented Apr 4, 2024

SuperSandro2000 commented Apr 4, 2024

Titaniumtown commented Apr 8, 2024

wyndon commented Apr 8, 2024 •

edited

Loading

Titaniumtown commented Apr 8, 2024

GaetanLepage commented Apr 8, 2024

LeonardAukea commented Apr 9, 2024

GaetanLepage commented Apr 9, 2024

bnjmnt4n commented Apr 9, 2024 •

edited

Loading

LeonardAukea commented Apr 9, 2024

jansol commented Apr 9, 2024

musjj commented Apr 9, 2024

SuperSandro2000 commented Apr 9, 2024 •

edited

Loading

zed-editor: init at 0.129.1 #284010

zed-editor: init at 0.129.1 #284010

Conversation

GaetanLepage commented Jan 26, 2024 • edited Loading

Description of changes

Things done

wegank left a comment

Choose a reason for hiding this comment

PaulGrandperrin commented Jan 26, 2024

NickCao commented Jan 26, 2024

PaulGrandperrin commented Jan 26, 2024

GaetanLepage commented Jan 26, 2024 • edited Loading

wegank commented Jan 27, 2024

GaetanLepage commented Jan 27, 2024

jansol commented Apr 3, 2024

GaetanLepage commented Apr 3, 2024

jansol commented Apr 3, 2024 • edited Loading

GaetanLepage commented Apr 4, 2024

jansol commented Apr 4, 2024

SuperSandro2000 commented Apr 4, 2024

Titaniumtown commented Apr 8, 2024

wyndon commented Apr 8, 2024 • edited Loading

Titaniumtown commented Apr 8, 2024

GaetanLepage commented Apr 8, 2024

LeonardAukea commented Apr 9, 2024

GaetanLepage commented Apr 9, 2024

bnjmnt4n commented Apr 9, 2024 • edited Loading

LeonardAukea commented Apr 9, 2024

jansol commented Apr 9, 2024

musjj commented Apr 9, 2024

SuperSandro2000 commented Apr 9, 2024 • edited Loading

GaetanLepage commented Jan 26, 2024 •

edited

Loading

GaetanLepage commented Jan 26, 2024 •

edited

Loading

jansol commented Apr 3, 2024 •

edited

Loading

wyndon commented Apr 8, 2024 •

edited

Loading

bnjmnt4n commented Apr 9, 2024 •

edited

Loading

SuperSandro2000 commented Apr 9, 2024 •

edited

Loading