[23.11] python311Packages.uamqp: add patches for CVE-2024-25110 & CVE-2024-27099 #293099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5b1f8af, modified)
risicle
added
the
1.severity: security
LeSuisse
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Patches looks fine, everything builds (no new failures).
Result of nixpkgs-review pr 293099 run on x86_64-linux 1
6 packages failed to build:
- baserow
- baserow.dist
- python310Packages.django-celery-beat
- python310Packages.django-celery-beat.dist
- python311Packages.django-celery-beat
- python311Packages.django-celery-beat.dist
87 packages built:
- dvc (python311Packages.dvc)
- dvc-with-remotes
- dvc-with-remotes.dist
- dvc.dist (python311Packages.dvc.dist)
- paperless-ngx
- python310Packages.azure-servicebus
- python310Packages.azure-servicebus.dist
- python310Packages.celery
- python310Packages.celery-redbeat
- python310Packages.celery-redbeat.dist
- python310Packages.celery-singleton
- python310Packages.celery-singleton.dist
- python310Packages.celery.dist
- python310Packages.django-celery-email
- python310Packages.django-celery-email.dist
- python310Packages.django-celery-results
- python310Packages.django-celery-results.dist
- python310Packages.django-google-analytics-app
- python310Packages.django-google-analytics-app.dist
- python310Packages.django-health-check
- python310Packages.django-health-check.dist
- python310Packages.django-raster
- python310Packages.django-raster.dist
- python310Packages.djmail
- python310Packages.djmail.dist
- python310Packages.dvc
- python310Packages.dvc-task
- python310Packages.dvc-task.dist
- python310Packages.dvc.dist
- python310Packages.dvclive
- python310Packages.dvclive.dist
- python310Packages.flower
- python310Packages.flower.dist
- python310Packages.kombu
- python310Packages.kombu.dist
- python310Packages.uamqp
- python310Packages.uamqp.dist
- python311Packages.azure-servicebus
- python311Packages.azure-servicebus.dist
- python311Packages.celery
- python311Packages.celery-redbeat
- python311Packages.celery-redbeat.dist
- python311Packages.celery-singleton
- python311Packages.celery-singleton.dist
- python311Packages.celery.dist
- python311Packages.django-celery-email
- python311Packages.django-celery-email.dist
- python311Packages.django-celery-results
- python311Packages.django-celery-results.dist
- python311Packages.django-google-analytics-app
- python311Packages.django-google-analytics-app.dist
- python311Packages.django-health-check
- python311Packages.django-health-check.dist
- python311Packages.django-raster
- python311Packages.django-raster.dist
- python311Packages.djmail
- python311Packages.djmail.dist
- python311Packages.dvc-task
- python311Packages.dvc-task.dist
- python311Packages.dvclive
- python311Packages.dvclive.dist
- python311Packages.flower
- python311Packages.flower.dist
- python311Packages.kombu
- python311Packages.kombu.dist
- python311Packages.uamqp
- python311Packages.uamqp.dist
- sourcehut.buildsrht
- sourcehut.buildsrht.dist
- sourcehut.coresrht
- sourcehut.coresrht.dist
- sourcehut.gitsrht
- sourcehut.gitsrht.dist
- sourcehut.hgsrht
- sourcehut.hgsrht.dist
- sourcehut.hubsrht
- sourcehut.hubsrht.dist
- sourcehut.listssrht
- sourcehut.listssrht.dist
- sourcehut.mansrht
- sourcehut.mansrht.dist
- sourcehut.metasrht
- sourcehut.metasrht.dist
- sourcehut.pastesrht
- sourcehut.pastesrht.dist
- sourcehut.todosrht
- sourcehut.todosrht.dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2024-25110
https://nvd.nist.gov/vuln/detail/CVE-2024-27099
Backport from #293035 not quite as simple as I'd hoped - CVE-2024-25110's patch depends on a file in the vendored
azure-uamqp-c's vendoredazure-c-shared-utilitywhich wasn't present in python-uamqp 1.6.5. Ended up having to include the patch adding it in-tree becausefetchpatchwill helpfully add anextraPrefixto all paths - including/dev/null- meaning theincludesoption won't be able to find files that are created in that patch.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.