Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: move the list of supportedSystems from pkgs/top-level/release.nix to lib/systems/doubles.nix #295083

Closed
wants to merge 1 commit into from

Conversation

philiptaron
Copy link
Contributor

Description of changes

This allows flakes which depend on nixpkgs to reference this list from nixpkgs.lib.systems.doubles.builtOnNixosHydra, which is a long name but very true. These are the doubles that are built on Hydra!

See also:

Things done

  • Ran nix-build pkgs/top-level/release.nix -A coreutils.x86_64-linux to see that release.nix worked
  • Ran nix-instantiate --strict --eval -A lib.systems.doubles.builtOnNixosHydra to see the list.
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Mar 11, 2024
@philiptaron
Copy link
Contributor Author

@adamcstephens I added you as a reviewer as you were the one who prompted me to make this PR on Matrix. 😀

@adamcstephens
Copy link
Contributor

Apparently we used to have tiers... 168b926#diff-63eb6a287d11186d38fb63525502771b216e734d2ea625a9b51c2b748871c632

@philiptaron
Copy link
Contributor Author

It's funny -- the replacement, nixpkgs#lib.systems.flakeExposed doesn't solve the thing because it's too large, including what I'd say are exotic platforms with tenuous support in Nix.

On the maybe list, but you're likely to have a lot of compilation to do:

  • armv7l-linux
  • i686-linux
  • riscv64-linux

On the will it work list:

  • armv6l-linux
  • mipsel-linux
  • armv5tel-linux
  • powerpc64le-linux

What flake users really want, and what I want this string for, is hot binary caches so that nix run and friends work in a decent amount of time. That's just the builtOnNixosHydra list.

@philiptaron philiptaron requested a review from infinisil March 14, 2024 20:56
@philiptaron philiptaron requested review from stephank and grahamc April 3, 2024 04:23
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
…x to lib/systems/doubles.nix

This allows flakes which depend on `nixpkgs` to reference this list from
`nixpkgs.lib.systems.doubles.builtOnNixosHydra`, which is a long name but very true.
These are the doubles that are built on [Hydra](https://hydra.nixos.org/)!

See also:
- https://github.com/NixOS/rfcs/blob/master/rfcs/0046-platform-support-tiers.md
- NixOS/rfcs#112 (closed)
@philiptaron philiptaron removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jul 26, 2024
@FliegendeWurst FliegendeWurst added the needs_reviewer (old Marvin label, do not use) label Nov 13, 2024
@philiptaron
Copy link
Contributor Author

I'm going to close this due to lack of interest from reviewers. It's a shame: having this information be as inaccessible as it currently is seems to me to serve no one, but I'm not willing to just force this sort of thing through without at least one person saying yes.

@philiptaron philiptaron closed this Dec 9, 2024
@philiptaron philiptaron deleted the tier1 branch December 9, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 needs_reviewer (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants