Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome.mutter: Add upstream-patch for wayland window-resizing issue #300634

Closed
wants to merge 1 commit into from

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Apr 1, 2024

Description of changes

Fixes issue that maximized windows are resized/moved after unlock (gdm)/suspend/dock/undock

Upstream issue: https://gitlab.gnome.org/GNOME/mutter/-/issues/1627
Upstream MR: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3601

Should be included in v46-release

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes issue that maximized windows are resized/moved after unlock
(gdm)/suspend/dock/undock

Upstream issue: https://gitlab.gnome.org/GNOME/mutter/-/issues/1627
Upstream MR: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3601
@SebTM SebTM requested a review from jtojnar as a code owner April 1, 2024 07:46
@SebTM SebTM requested a review from amaxine April 1, 2024 07:46
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 1, 2024
@ofborg ofborg bot requested review from hedning, dasj19 and bobby285271 April 1, 2024 08:14
@amaxine
Copy link
Contributor

amaxine commented Apr 1, 2024

The patch seems safe to apply to 45, but I'm not sure I'm super keen on landing this as we're aiming to ship 46 hopefully soon.

@SebTM
Copy link
Contributor Author

SebTM commented Apr 1, 2024

The patch seems safe to apply to 45, but I'm not sure I'm super keen on landing this as we're aiming to ship 46 hopefully soon.

However you prefer, should we keep it open for others/tracking it's still fixed when v46 is released?

@amaxine amaxine mentioned this pull request Apr 1, 2024
27 tasks
@amaxine
Copy link
Contributor

amaxine commented Apr 1, 2024

Sounds good. I'm also not opposed to someone else merging this, I'm just personally not loving the idea of landing this patch now of all times 🙂

I'd also encourage testing GNOME 46 in lieu of getting this in, to anyone who can.

@jtojnar
Copy link
Member

jtojnar commented Apr 24, 2024

46 is in staging-next.

@jtojnar jtojnar closed this Apr 24, 2024
@SebTM SebTM deleted the gnome_mutter-wayland3601 branch April 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants