Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invidious: 0.20.1-unstable-2024-03-08 -> 0.20.1-unstable-2024-03-31 #300643

Merged
1 commit merged into from
Apr 1, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Apr 1, 2024

Description of changes

Fixes #300537

cc @sbruder @infinisil @999eagle

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage marked this pull request as ready for review April 1, 2024 08:15
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 300643 run on x86_64-linux 1

1 package built:
  • invidious

Copy link
Member

@sefidel sefidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested functionality.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 300643 run on aarch64-linux 1

1 package built:
  • invidious

@ghost ghost merged commit cb13a6d into NixOS:master Apr 1, 2024
32 of 33 checks passed
@GaetanLepage GaetanLepage deleted the invidious branch April 1, 2024 12:03
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-300643-to-release-23.11 origin/release-23.11
cd .worktree/backport-300643-to-release-23.11
git switch --create backport-300643-to-release-23.11
git cherry-pick -x e79cebc3bfa79f79945b3f831ae1f52bd1e52407

pSub added a commit that referenced this pull request Apr 8, 2024
…0643

Invidious unstable-2023-11-08 -> 0.20.1-unstable-2024-03-31 (backport of #300643)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: invidious 0.20.1-unstable-2024-03-08 → 0.20.1-unstable-2024-03-31
3 participants