factorio: use requireFile with better error msg and split off API docs to devdoc #301816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing Specifically display the *actual* releaseType and version that they have to fetch manually instead of expecting them to derive this information from the full path of the derivation that just failed to build.
ofborg
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
10.rebuild-linux: 1-10
and removed
10.rebuild-linux: 0
muggenhor
changed the title
FliegendeWurst
added
the
2.status: merge conflict
There was a problem hiding this comment.
This was moved to pkgs/by-name
Merged
13 tasks
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically display the actual
releaseTypeandversionthat they have to fetch manually instead of expecting them to derive this information from the full path of the derivation that just failed to build.On top of that this splits the developer/API documentation to a separate
devdocoutput. Allowing most users to save on the ~100 MiB that this occupies. (Note this is basically an offline copy of https://lua-api.factorio.com/latest/ )Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.