-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfsUnstable: 2.2.3-unstable-2024-04-09 -> 2.2.3-unstable-2024-04-20 [enables linux 6.8] #305682
Conversation
Also enables linux 6.8.
Result of 21 packages built:
|
version = "2.2.3-unstable-2024-04-09"; | ||
rev = "28520cad2500b60ce8653e431990e33f77ff08f7"; | ||
version = "2.2.3-unstable-2024-04-20"; | ||
rev = "f4f156157de3f61e55db0429b10c63d02226e115"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit appears to be from master and not the tip of zfs-2.2.4-staging. Does this include any in progress code meant for 2.3 despite the kernel bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. This commit doesn’t follow the stated policy here. Current latest on the branch is 72e4996a54fe54b93bf1e667a5e60099375fe08f
.
version = "2.2.3-unstable-2024-04-09"; | ||
rev = "28520cad2500b60ce8653e431990e33f77ff08f7"; | ||
version = "2.2.3-unstable-2024-04-20"; | ||
rev = "f4f156157de3f61e55db0429b10c63d02226e115"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. This commit doesn’t follow the stated policy here. Current latest on the branch is 72e4996a54fe54b93bf1e667a5e60099375fe08f
.
FWIW 2.2.4 patchset PR was just merged (openzfs/zfs#16107), so maybe it makes sense to bump the PR to that version? |
I think that’s probably fine. Though may make sense to just wait for 2.2.4 to be tagged as that shouldn’t be long. |
2.2.4 is tagged upstream; see #308642 |
OK, let's close this in favour of #308642 then |
Upstream now supports 6.8 in their META: openzfs/zfs@454c0b0
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.