Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsUnstable: 2.2.3-unstable-2024-04-09 -> 2.2.3-unstable-2024-04-20 [enables linux 6.8] #305682

Closed
wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 21, 2024

Upstream now supports 6.8 in their META: openzfs/zfs@454c0b0

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Apr 21, 2024
@nbraud nbraud requested review from amarshall and adamcstephens May 2, 2024 14:27
@nbraud
Copy link
Contributor

nbraud commented May 2, 2024

Result of nixpkgs-review pr 305682 run on x86_64-linux 1

21 packages built:
  • linuxKernel.packages.linux_4_19.zfs_unstable
  • linuxPackages_4_19_hardened.zfs_unstable (linuxKernel.packages.linux_4_19_hardened.zfs_unstable)
  • linuxKernel.packages.linux_5_10.zfs_unstable
  • linuxPackages_5_10_hardened.zfs_unstable (linuxKernel.packages.linux_5_10_hardened.zfs_unstable)
  • linuxKernel.packages.linux_5_15.zfs_unstable
  • linuxPackages_5_15_hardened.zfs_unstable (linuxKernel.packages.linux_5_15_hardened.zfs_unstable)
  • linuxKernel.packages.linux_5_4.zfs_unstable
  • linuxPackages_5_4_hardened.zfs_unstable (linuxKernel.packages.linux_5_4_hardened.zfs_unstable)
  • linuxKernel.packages.linux_6_1.zfs_unstable
  • linuxPackages_6_1_hardened.zfs_unstable (linuxKernel.packages.linux_6_1_hardened.zfs_unstable)
  • linuxPackages.zfs_unstable (linuxKernel.packages.linux_6_6.zfs_unstable)
  • linuxPackages_hardened.zfs_unstable (linuxPackages_6_6_hardened.zfs_unstable)
  • linuxPackages_latest.zfs_unstable (linuxKernel.packages.linux_6_8.zfs_unstable)
  • linuxPackages_latest-libre.zfs_unstable (linuxKernel.packages.linux_latest_libre.zfs_unstable)
  • linuxPackages-libre.zfs_unstable (linuxKernel.packages.linux_libre.zfs_unstable)
  • linuxPackages_lqx.zfs_unstable (linuxKernel.packages.linux_lqx.zfs_unstable)
  • linuxPackages_xanmod.zfs_unstable (linuxKernel.packages.linux_xanmod.zfs_unstable)
  • linuxPackages_xanmod_latest.zfs_unstable (linuxKernel.packages.linux_xanmod_latest.zfs_unstable ,linuxPackages_xanmod_stable.zfs_unstable)
  • linuxPackages_zen.zfs_unstable (linuxKernel.packages.linux_zen.zfs_unstable)
  • zfs_unstable
  • zfs_unstable.dev

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 2, 2024
version = "2.2.3-unstable-2024-04-09";
rev = "28520cad2500b60ce8653e431990e33f77ff08f7";
version = "2.2.3-unstable-2024-04-20";
rev = "f4f156157de3f61e55db0429b10c63d02226e115";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit appears to be from master and not the tip of zfs-2.2.4-staging. Does this include any in progress code meant for 2.3 despite the kernel bump?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. This commit doesn’t follow the stated policy here. Current latest on the branch is 72e4996a54fe54b93bf1e667a5e60099375fe08f.

version = "2.2.3-unstable-2024-04-09";
rev = "28520cad2500b60ce8653e431990e33f77ff08f7";
version = "2.2.3-unstable-2024-04-20";
rev = "f4f156157de3f61e55db0429b10c63d02226e115";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. This commit doesn’t follow the stated policy here. Current latest on the branch is 72e4996a54fe54b93bf1e667a5e60099375fe08f.

@jaen
Copy link
Contributor

jaen commented May 2, 2024

FWIW 2.2.4 patchset PR was just merged (openzfs/zfs#16107), so maybe it makes sense to bump the PR to that version?

@amarshall
Copy link
Member

I think that’s probably fine. Though may make sense to just wait for 2.2.4 to be tagged as that shouldn’t be long.

@amarshall
Copy link
Member

2.2.4 is tagged upstream; see #308642

@nbraud
Copy link
Contributor

nbraud commented May 3, 2024

OK, let's close this in favour of #308642 then

@nbraud nbraud closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants