Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq: default to version 8.19 #307816

Merged
merged 1 commit into from
Apr 30, 2024
Merged

coq: default to version 8.19 #307816

merged 1 commit into from
Apr 30, 2024

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vbgl vbgl added the 6.topic: coq "A formal proof management system" label Apr 29, 2024
Princemachiavelli
Princemachiavelli approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@Princemachiavelli Princemachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I do not see any other breaking packages besides why3.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 30, 2024
@wegank
Copy link
Member

wegank commented Apr 30, 2024 •
edited
Loading

Do we want NixOS 24.05 to ship Coq 8.19 by default? (And also, if there's any release blocker (#303286) for Coq or OCaml)

@vbgl
Copy link
Contributor Author

vbgl commented Apr 30, 2024

Do we want NixOS 24.05 to ship Coq 8.19 by default?

Sounds like a good idea, to me at least.

And also, if there's any release blocker for Coq or OCaml

I’m not aware of any such release blocker.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Apr 30, 2024
@wegank
Copy link
Member

wegank commented Apr 30, 2024

Result of nixpkgs-review pr 307816 run on x86_64-linux 1

72 packages built:
  • compcert (coqPackages.compcert)
  • compcert.doc (coqPackages.compcert.doc)
  • compcert.lib (coqPackages.compcert.lib)
  • compcert.man (coqPackages.compcert.man)
  • coq (coqPackages.coq)
  • coqPackages.Cheerios
  • coqPackages.CoLoR
  • coqPackages.HoTT
  • coqPackages.ITree
  • coqPackages.InfSeqExt
  • coqPackages.LibHyps
  • coqPackages.QuickChick
  • coqPackages.StructTact
  • coqPackages.VST
  • coqPackages.aac-tactics
  • coqPackages.bignums
  • coqPackages.ceres
  • coqPackages.coq-elpi
  • coqPackages.coq-ext-lib
  • coqPackages.coq-lsp
  • coqPackages.coq-record-update
  • coqPackages.coqide
  • coqPackages.coqprime
  • coqPackages.coquelicot
  • coqPackages.corn
  • coqPackages.deriving
  • coqPackages.dpdgraph
  • coqPackages.equations
  • coqPackages.extructures
  • coqPackages.flocq
  • coqPackages.fourcolor
  • coqPackages.gappalib
  • coqPackages.hierarchy-builder
  • coqPackages.interval
  • coqPackages.iris
  • coqPackages.iris-named-props
  • coqPackages.itauto
  • coqPackages.math-classes
  • coqPackages.mathcomp
  • coqPackages.mathcomp-algebra
  • coqPackages.mathcomp-algebra-tactics
  • coqPackages.mathcomp-analysis
  • coqPackages.mathcomp-bigenough
  • coqPackages.mathcomp-character
  • coqPackages.mathcomp-classical
  • coqPackages.mathcomp-field
  • coqPackages.mathcomp-fingroup
  • coqPackages.mathcomp-finmap
  • coqPackages.mathcomp-infotheo
  • coqPackages.mathcomp-real-closed
  • coqPackages.mathcomp-solvable
  • coqPackages.ssreflect (coqPackages.mathcomp-ssreflect)
  • coqPackages.mathcomp-word
  • coqPackages.mathcomp-zify
  • coqPackages.metacoq
  • coqPackages.metacoq-erasure
  • coqPackages.metacoq-pcuic
  • coqPackages.metacoq-safechecker
  • coqPackages.metacoq-template-coq
  • coqPackages.multinomials
  • coqPackages.paco
  • coqPackages.paramcoq
  • coqPackages.parsec
  • coqPackages.reglang
  • coqPackages.serapi
  • coqPackages.simple-io
  • coqPackages.stdpp
  • coqPackages.vcfloat
  • coqPackages.vscoq-language-server
  • coqPackages.zorns-lemma
  • framac
  • satallax

@wegank wegank merged commit 144871c into NixOS:master Apr 30, 2024
29 of 30 checks passed
@vbgl vbgl deleted the coq-default-8.19 branch April 30, 2024 15:23
@wegank wegank mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@Princemachiavelli Princemachiavelli Princemachiavelli approved these changes

Assignees
No one assigned
Labels
6.topic: coq "A formal proof management system" 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbgl @wegank @Princemachiavelli