llvmPackages_{17,18,git}.compiler-rt: revert to dynamic checks on older SDKs #309385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er SDKs compiler-rt uses weak linkage for `_availability_version_check` as of LLVM 17, but that means it requires the 10.15 SDK to link. Revert the change on older SDKs, so they can continue using availability checks.
3 tasks
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
rrbutani
added
the
6.topic: llvm/clang
wegank
added
the
2.status: merge conflict
|
I think we won’t need this since we’re bumping the required macOS version in the same release we bump to LLVM 19 – please re‐open if I’m wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
compiler-rt uses weak linkage for
_availability_version_checkas of LLVM 17, but that means it requires the 10.15 SDK to link. Revert the change on older SDKs, so they can continue using availability checks.Testing was done by confirming that Python 3 compiles with clang 18 on x86_64-darwin. Without the patch, it fails due to missing symbols.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.