Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beam-migrate: jailbreak because of too strict upper bound on pqueue #309920

Merged
merged 1 commit into from
May 11, 2024

Conversation

laaksonel
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label May 7, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 7, 2024
@maralorn
Copy link
Member

maralorn commented May 9, 2024

Can you maybe add a link to an issue or PR upstream?
And or we could use an assert sothat we remember dropping the jailbreak on the next version bump.

@laaksonel
Copy link
Contributor Author

haskell-beam/beam#705

@maralorn
Copy link
Member

Excellent, thank you.

@maralorn
Copy link
Member

For future reference: better to prefix the commitmessage with haskellPackages if the package is not a top level attribute.

@maralorn maralorn merged commit cc1aa4c into NixOS:haskell-updates May 11, 2024
19 checks passed
@laaksonel
Copy link
Contributor Author

For future reference: better to prefix the commitmessage with haskellPackages if the package is not a top level attribute.

Noted, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants