uboot: build failure with older versions #311614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
- fix for build failure with version older than v2023.07 Signed-off-by: Ganga Ram <[email protected]>
Mic92
force-pushed
the
pr/builduboot-failure
branch
from
f85106e to
ffb92fa
Compare
Mic92
approved these changes
May 14, 2024
wegank
added
the
12.approvals: 1
gngram
added a commit
to gngram/nixos-hardware
that referenced
this pull request
May 16, 2024
The buildUBoot function was originally intended for internal use and is dedicated for Raspberry Pi platforms. With latest nixpkgs it is causing build failure due to an Raspberry Pi patch. This function has been removed from the U-Boot build configuration. More Information: NixOS/nixpkgs#311614 NixOS/nixpkgs#146634 Signed-off-by: Ganga Ram <[email protected]>
2 tasks
gngram
added a commit
to gngram/nixos-hardware
that referenced
this pull request
May 16, 2024
The buildUBoot function is intended for internal use and is dedicated for Raspberry Pi platforms. With latest nixpkgs it is causing build failure in older uboot(prior to v2023.07) due to a Raspberry Pi patch. Now this function is not used for the U-Boot build. More Information: NixOS/nixpkgs#311614 NixOS/nixpkgs#146634 Signed-off-by: Ganga Ram <[email protected]>
2 tasks
mergify bot
pushed a commit
to NixOS/nixos-hardware
that referenced
this pull request
May 16, 2024
The buildUBoot function is intended for internal use and is dedicated for Raspberry Pi platforms. With latest nixpkgs it is causing build failure in older uboot(prior to v2023.07) due to a Raspberry Pi patch. Now this function is not used for the U-Boot build. More Information: NixOS/nixpkgs#311614 NixOS/nixpkgs#146634 Signed-off-by: Ganga Ram <[email protected]>
|
The I'm closing under the assumption that NixOS/nixos-hardware#947 was the alternative fix for your issue. |
CHN-beta
pushed a commit
to CHN-beta/nixos-hardware
that referenced
this pull request
May 21, 2024
The buildUBoot function is intended for internal use and is dedicated for Raspberry Pi platforms. With latest nixpkgs it is causing build failure in older uboot(prior to v2023.07) due to a Raspberry Pi patch. Now this function is not used for the U-Boot build. More Information: NixOS/nixpkgs#311614 NixOS/nixpkgs#146634 Signed-off-by: Ganga Ram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix for build failure with version older than v2023.07.
The patch 0001-configs-rpi-allow-for-bigger-kernels.patch is hardware specific. It tries to modify a file
board/raspberrypi/rpi/rpi.envwhich doesn't exist in uboot older than v2023.07 thus the patch fails and so uboot build.Moved the patch to hardware specific targets.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.