Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pe-parse: fix build on darwin #315748

Merged
merged 1 commit into from
May 30, 2024
Merged

pe-parse: fix build on darwin #315748

merged 1 commit into from
May 30, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented May 30, 2024 •
edited
Loading

Description of changes

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 30, 2024
@ofborg ofborg bot requested a review from arcz May 30, 2024 01:10
@wegank
Copy link
Member Author

wegank commented May 30, 2024

Result of nixpkgs-review pr 315748 run on aarch64-darwin 1

2 packages built:
  • pe-parse
  • uthenticode

risicle
risicle approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nixpkgs-review happy, macos 12 x86_64

@risicle risicle merged commit 3f15210 into NixOS:master May 30, 2024
33 checks passed
@risicle risicle added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.05 labels May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

@wegank wegank deleted the pe-parse-darwin branch May 30, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@arcz arcz Awaiting requested review from arcz

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wegank @risicle