nadesiko3: init at 3.6.22 #317222
Draft
nadesiko3: init at 3.6.22 #317222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
donovanglover
force-pushed
the
nadesiko3
branch
from
d863c41 to
b1e80ad
Compare
natsukium
reviewed
Aug 3, 2024
There was a problem hiding this comment.
Could you please submit an issue to ask the upstream to commit package-lock.json?
We do not want to commit lock files to nixpkgs if possible. (see #327064)
Adding lock files to the upstream repository should have a positive impact on the upstream development.
https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json
Also, looking at the upstream repository, it seems that all issues are written in Japanese. But I guess it doesn't matter if you post it in English.
If you need help, feel free to let me know.
There was a problem hiding this comment.
Upstream rejected adding package-lock.json due to potential issues and recommends to generate package-lock.json instead
donovanglover
force-pushed
the
nadesiko3
branch
from
b1e80ad to
43ad022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds https://nadesi.com
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.