libgit2: 1.7.2 -> 1.8.1; python312Packages.pygit2: 1.14.1 -> 1.15.0

[eclairevoyant]

Description of changes

• 1.7.2 -> 1.8.1
  • This also replaces the dependency on the abandoned http-parser with llhttp.
• fix incorrect recursive structure in tests (tracking issue: Lint on broken recursion structure #312345)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[SuperSandro2000]

LGTM, please test the reverse deps enough to not cause to many breakges

[eclairevoyant]

please test the reverse deps enough to not cause to many breakges

unfortunately there are lots of breakages, I'm trying to go through them when I get a chance, hence left the PR in draft for now

[SuperSandro2000]

I meant the key reverse deps listed in passthru 😅

[trofi]

Bisect claims that 602760c libgit2: fix incorrect recursive structure in tests broke the eval of libgit2.tests in staging as:

$ nix build --no-link -f. libgit2.tests

error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at pkgs/development/libraries/libgit2/default.nix:73:40:
           72|
           73|   passthru.tests = lib.mapAttrs (_: v: v.override { libgit2 = finalAttrs.finalPackage; }) {
             |                                        ^
           74|     inherit libgit2-glib;

       … while calling a functor (an attribute set with a '__functor' attribute)
         at lib/customisation.nix:144:43:
          143|       # Re-call the function but with different arguments
          144|       overrideArgs = mirrorArgs (newArgs: makeOverridable f (overrideWith newArgs));
             |                                           ^
          145|       # Change the result of the function call by applying g to it

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: function 'anonymous lambda' called with unexpected argument 'libgit2'
       at pkgs/applications/version-management/gitstatus/default.nix:1:1:
            1| { callPackage, lib, stdenv, fetchFromGitHub, git, zsh }:
             | ^
            2|

I think it says that gitstatus does not have an immediate libgit2 input.

[eclairevoyant]

Thanks for catching.
And yikes, how would we even override that? it's coming in via buildInputs = [ (callPackage ./romkatv_libgit2.nix { }) ]; which in turn has a libgit2 input...

[SuperSandro2000]

I try to take a look at this later today