Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

megatools: 1.11.0 -> 1.11.1 #319867

Closed
wants to merge 3 commits into from
Closed

megatools: 1.11.0 -> 1.11.1 #319867

wants to merge 3 commits into from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review June 14, 2024 18:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4095

@pbsbot
Copy link

pbsbot commented Jun 19, 2024

Result of nixpkgs-review pr 319867 run on x86_64-linux 1

3 packages built:
  • megatools
  • megatools.doc
  • megatools.man

@pbsds pbsds requested a review from viric June 19, 2024 18:57
@AndersonTorres
Copy link
Member Author

@viric is dormant:

#290642

- get rid of nested with
- split outputs
- remove viric from maintainers
@AndersonTorres
Copy link
Member Author

oh hell, now I need to run formatter on everything - even semi-abandoned PRs...

@AndersonTorres
Copy link
Member Author

Closing because I am tired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants