buildGoModule: accept fixed-point function argument

[ehmry]

Make it possible to use buildGoModule (finalAttrs: { instead of buildGoModule rec {.

I'm hoping this is a zero-rebuild change.

Related: #225051 #234651 #317559

---

Add a 👍 reaction to pull requests you find important.

[Aleksanaa]

Support for finalAttrs is good, but replacing all occurrence of rec, especially those only using rev = version, doesn't bring any immediate benefit. See #310373

[ehmry]

The immediate benefit is that there is consistency, and consistency perpetuates more consistency because people look at other packages for examples.

[ehmry]

I did this because its good to have the option of using finalAttrs and because it makes buildGoModule consistent with what we are recommending elsewhere.

Changing packages that are using rec shows that it can be done without effecting outputs, but it isn't necessary so the second commit doesn't need to be merged.

[zowoq]

Please split formatting to another commit.

[ehmry]

There are actually quite a few places where overriding version and src later isn't going to be correct, see git grep -n -- '-X=g' pkgs.

[Mic92]

The immediate benefit is that there is consistency, and consistency perpetuates more consistency because people look at other packages for examples.

A different problem is that it has a negative impact on eval performance because of fixed-output computation - So I don't think we should use this everywhere in nixpkgs, but only if we need it.

Reformatting removed.

[philiptaron]

@ehmry mind if I force-push this to fix the merge conflict?

[ehmry]

@philiptaron yes, fine by me

[ShamrockLee]

This commit needs rebasing, as #225051 is merged.