-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yazi-unwrapped: build new yazi-cli tool #321937
Conversation
Result of 2 packages built:
|
Tested the tool a little bit following the yazi DDS docs page and it seems to work. Testing steps
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yazi the wrapper also need to be changed to make ya
available.
@@ -25,6 +25,8 @@ rustPlatform.buildRustPackage rec { | |||
|
|||
env.YAZI_GEN_COMPLETIONS = true; | |||
|
|||
cargoBuildFlags = ["-p" "yazi-fm" "-p" "yazi-cli"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added it to default-members
, so we can remove this next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you think we should just wait for the next release or do we add a message like this:
# remove in the next release
cargoBuildFlags = ["-p" "yazi-fm" "-p" "yazi-cli"];
Since the wrapper changed in 321076, I didn't want to modify it here until it was merged to avoid conflicts. Would it have been better if I opened this as a draft, perhaps? |
In addition to the main program, there is a new CLI tool, now: sxyazi/yazi#914
The wrapper PR was merged so I've added the cli tool to the wrapper, tested again, and everything appears to be working. I've also added a note to remove the cargo flags in the next release. |
Description of changes
See sxyazi/yazi#914
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.