Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: remove patka #323872

Merged
merged 1 commit into from
Jul 1, 2024
Merged

maintainers: remove patka #323872

merged 1 commit into from
Jul 1, 2024

Conversation

patka-123
Copy link
Contributor

Description of changes

I gave it a second chance, but that was too naive. pennea said it well in #323845

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 1, 2024
@Janik-Haag Janik-Haag requested a review from infinisil July 1, 2024 19:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 1, 2024
0x4A6F
0x4A6F approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 1, 2024
@yayayayaka yayayayaka merged commit 1d16351 into NixOS:master Jul 1, 2024
25 checks passed
@patka-123 patka-123 deleted the remove-patka branch July 2, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yayayayaka yayayayaka yayayayaka approved these changes

@0x4A6F 0x4A6F 0x4A6F approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@drupol drupol Awaiting requested review from drupol

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patka-123 @0x4A6F @yayayayaka @wegank