-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atlauncher: build from source #327592
atlauncher: build from source #327592
Conversation
Seems like the build fails on
Wondering if I should revert to just getting the JAR and wrapping that instead of getting the EXE as well, since the latter breaks on one platform as of writing. |
I'd recommend avoiding Launch4j if possible, it's just unnecessary native code. I doubt launch4j-3.50-workdir-linux.jar would work on aarch64, it's more likely it's targeting i686. |
Unsure how would I go about avoiding Launch4j. This is my first and only Gradle package that I maintain + I don't know much about Gradle/Launch4j. Could you please elaborate/provide a reference? Thanks. |
basically, instead of building the exe, you build the jar and wrap it. To do that, you find out what task is responsible for building the jar and set gradleBuildTask appropriately. |
Ah okay, that's what I was doing initially anyway. I'll do that again in a bit. |
5497b8f
to
ba5e11c
Compare
This is weird, even after setting |
perhaps you can find the answer with |
This says |
Description of changes
Thanks to chayleaf's efforts in #272380, it's much easier to package apps built with Gradle!
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.