Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.wfuzz: fix build on Python 3.12 #329970

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ghpzin
Copy link
Contributor

@ghpzin ghpzin commented Jul 25, 2024

Description of changes

Fixes #326902 (wfuzz build failure)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghpzin

This comment was marked as outdated.

@ghpzin ghpzin marked this pull request as ready for review July 25, 2024 20:24
@ghpzin ghpzin marked this pull request as draft July 30, 2024 09:01
@ghpzin ghpzin force-pushed the wfuzz-fix-python312-build branch from 4121bbd to a1e2845 Compare July 30, 2024 09:41
@ghpzin

This comment was marked as outdated.

@ghpzin ghpzin marked this pull request as ready for review July 30, 2024 12:44

# fix distutils use for Python 3.12
substituteInPlace src/wfuzz/plugin_api/base.py \
--replace "from distutils import util" "from setuptools._distutils import util"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--replace "from distutils import util" "from setuptools._distutils import util"
--replace-fail "from distutils import util" "from setuptools._distutils import util"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- add patch from upstream PR fixing imp module uses
- disable test depending on imp module
- replace distutils with setuptools._distutils
@ghpzin ghpzin force-pushed the wfuzz-fix-python312-build branch from a1e2845 to e2d06ea Compare July 30, 2024 19:53
@ghpzin
Copy link
Contributor Author

ghpzin commented Jul 31, 2024

Result of nixpkgs-review pr 329970 run on x86_64-linux 1

5 packages built:
  • python311Packages.wfuzz
  • python311Packages.wfuzz.dist
  • wfuzz (python312Packages.wfuzz)
  • wfuzz.dist (python312Packages.wfuzz.dist)
  • wordlists

@SuperSandro2000 SuperSandro2000 merged commit acdc1a7 into NixOS:master Jul 31, 2024
23 checks passed
@ghpzin ghpzin deleted the wfuzz-fix-python312-build branch July 31, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wfuzz error - no module named 'imp'
3 participants