bitwarden-desktop: 2024.6.4 -> 2024.8.0 #330137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
Any idea how to fix this issue? This draft looks stale from an outsiders perspective |
No. I tried rebuilding argon2 from source but to no avail. |
|
I found only one mention of the same issue so far, and thats: ranisalt/node-argon2#405 Maybe this gives you some idea |
|
We really need to solve this urgently: #335850 |
SuperSandro2000
force-pushed
the
bitwarden-desktop
branch
from
ba04e5d to
f0c26ec
Compare
dotlambda
force-pushed
the
bitwarden-desktop
branch
from
f0c26ec to
20a2daa
Compare
|
@SuperSandro2000 Is there a reason you added |
|
I think you did the change in the wrong commit. I just rebased on master. I can't really test this right now since electron_31 is not cached yet. |
|
@SuperSandro2000 This is not ready for review. The app still fails to launch.
You can replace |
ofborg
bot
added
10.rebuild-darwin: 0
see also the first entry in the faq https://github.com/ranisalt/node-argon2#faq I am currently trying that locally with semi success. |
That's outdated: ranisalt/node-argon2#411 |
|
I tried the following diff and it didn't change much about the error: diff --git a/pkgs/by-name/bi/bitwarden-desktop/package.nix b/pkgs/by-name/bi/bitwarden-desktop/package.nix
index 56021fd0e794..6b70cc1eca6c 100644
--- a/pkgs/by-name/bi/bitwarden-desktop/package.nix
+++ b/pkgs/by-name/bi/bitwarden-desktop/package.nix
@@ -3,7 +3,7 @@
, cargo
, copyDesktopItems
, dbus
-, electron_31
+, electron_31-bin
, fetchFromGitHub
, glib
, gnome-keyring
@@ -15,6 +15,7 @@
, moreutils
, napi-rs-cli
, nodejs_20
+, node-gyp
, patchutils_0_4_2
, pkg-config
, python3
@@ -26,7 +27,7 @@
let
description = "Secure and free password manager for all of your devices";
icon = "bitwarden";
- electron = electron_31;
+ electron = electron_31-bin;
in buildNpmPackage rec {
pname = "bitwarden-desktop";
version = "2024.7.1";
@@ -76,6 +77,7 @@
makeWrapper
moreutils
napi-rs-cli
+ node-gyp
pkg-config
(python3.withPackages (ps: with ps; [ setuptools ]))
rustc
@@ -95,6 +97,12 @@
exit 1
fi
+ pushd node_modules/argon2
+ node-gyp rebuild
+ popd
+
pushd apps/desktop/desktop_native/napi
npm run build
popdEdit: another attempt with |
|
I’ve been away for a bit, I will have some time to look into this a bit more Monday, or possibly sooner. |
Diff: bitwarden/clients@desktop-v2024.6.4...desktop-v2024.8.0 Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.7.1 https://github.com/bitwarden/clients/releases/tag/desktop-v2024.8.0 Co-authored-by: Andrew Marshall <[email protected]>
dotlambda
changed the title
dotlambda
force-pushed
the
bitwarden-desktop
branch
from
20a2daa to
e20d2b6
Compare
|
Figured out the issue, see #337164. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently fails to launch with
Description of changes
Diff: bitwarden/clients@desktop-v2024.6.4...desktop-v2024.8.0
Changelog:
https://github.com/bitwarden/clients/releases/tag/desktop-v2024.7.1
https://github.com/bitwarden/clients/releases/tag/desktop-v2024.8.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)related: #325428
Add a 👍 reaction to pull requests you find important.