prismlauncher: support all openal binary backends #330394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
Tungsten842
suggested changes
Jul 27, 2024
getchoo
force-pushed
the
pkgs/prismlauncher/openal
branch
from
c86a86a to
efe764c
Compare
ofborg
bot
added
the
2.status: merge conflict
Scrumplex
approved these changes
Aug 7, 2024
Scrumplex
added
12.approvals: 1
|
This has some conflicts with the master branch |
Previously we only included `libpulseaudio` in the wrapper, which limited the binary version of OpenAL provided by the launcher from using it's other backends. This also better documents what dependencies are for what part of lwjgl Fixes NixOS#330154
getchoo
force-pushed
the
pkgs/prismlauncher/openal
branch
from
efe764c to
ae25abb
Compare
getchoo
removed
the
2.status: merge conflict
Scrumplex
approved these changes
Aug 10, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-330394-to-release-24.05 origin/release-24.05
cd .worktree/backport-330394-to-release-24.05
git switch --create backport-330394-to-release-24.05
git cherry-pick -x ae25abbadfa8f2958624f7e226fdc4f44034eba6 |
|
The backport seems very non-trivial, i'll leave it to @getchoo to decide whether the effort is worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously we only included
libpulseaudioin the wrapper, which limited the binary version of OpenAL provided by the launcher from using it's other backends. This also better documents what dependencies are for what part of lwjglFixes #330154
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.