Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assertions for etc.overlay and systemd-sysusers #332516

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

nikstur
Copy link
Contributor

@nikstur nikstur commented Aug 5, 2024

Description of changes

Fixes #328926 (comment)

Remove unneeded/wrong assertions

Closes #311665

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur requested a review from Mic92 August 5, 2024 15:53
@nikstur nikstur requested a review from a team as a code owner August 5, 2024 15:53
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd labels Aug 5, 2024
@nikstur nikstur changed the title Etc overlay sysusers assertions Improve assertions for etc.overlay and systemd-sysusers Aug 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 5, 2024
@nikstur nikstur requested a review from arianvp August 6, 2024 07:21
@ivan770
Copy link
Member

ivan770 commented Aug 6, 2024

This PR should also close #311665.

@nikstur nikstur requested a review from WilliButz August 31, 2024 13:03
@Mic92 Mic92 merged commit 15f80d9 into NixOS:master Sep 23, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled users.mutableUsers conflicts with mutable overlay-based /etc
3 participants