Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godot_4: 4.2.2-stable -> 4.3-stable #334868

Merged
merged 4 commits into from
Aug 16, 2024
Merged

godot_4: 4.2.2-stable -> 4.3-stable #334868

merged 4 commits into from
Aug 16, 2024

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Aug 15, 2024 •
edited
Loading

godot_4: 4.2.2-stable -> 4.3-stable

  • migrate to pkgs/by-name
  • refactor
  • nixfmt
  • order by phases order, alphabetical order
  • fix cross compilation

Fixes #334942

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Aug 15, 2024
@superherointj superherointj marked this pull request as draft August 15, 2024 14:17
@superherointj superherointj changed the title godot_4: fix cross compiling godot_4: migrate to pkgs/by-name Aug 15, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 15, 2024
@superherointj superherointj marked this pull request as ready for review August 15, 2024 15:52
@Schweber
Copy link
Contributor

Schweber commented Aug 15, 2024 •
edited
Loading

v4.3 was released today. Can you include that as well?

If you do, can you please make the package so that pure wayland works (wayland support has been added in this version)?

@superherointj
Copy link
Contributor Author

superherointj commented Aug 15, 2024 •
edited
Loading

v4.3 was released today. Can you include that as well?

Done.

If you do, can you please make the package so that pure wayland works (wayland support has been godotengine/godot#86180 in this version)?

Feel free to open a PR for it.

@superherointj superherointj requested a review from Schweber August 15, 2024 18:58
@superherointj
godot_4: refactor
52acc68 
- nixfmt
- order by phases order, alphabetical order
- enable strictDeps
@superherointj
godot_4: migrate to pkgs/by-name
1747d9a
@superherointj superherointj force-pushed the godot_4-refactor branch 2 times, most recently from 993c5aa to ee45358 Compare August 15, 2024 20:00
@superherointj
godot_4: fix cross compilation
26eb674 
Co-authored-by: Anderson Torres
@superherointj superherointj changed the title godot_4: migrate to pkgs/by-name godot_4: migrate to pkgs/by-name, fix cross compilation Aug 15, 2024
@superherointj superherointj changed the title godot_4: migrate to pkgs/by-name, fix cross compilation godot_4: 4.2.2-stable -> 4.3-stable Aug 15, 2024
@superherointj superherointj mentioned this pull request Aug 15, 2024
Closed
13 tasks
@superherointj
Copy link
Contributor Author

superherointj commented Aug 15, 2024 •
edited
Loading

@Schweber @Haskellered Please review.

@Haskellered
Copy link

LGTM

@superherointj superherointj added awaiting_merger (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) labels Aug 15, 2024
AndersonTorres
AndersonTorres approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@superherointj superherointj merged commit 510fbb4 into NixOS:master Aug 16, 2024
38 of 40 checks passed
@superherointj superherointj deleted the godot_4-refactor branch August 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@shiryel shiryel Awaiting requested review from shiryel

@wegank wegank Awaiting requested review from wegank

@Schweber Schweber Awaiting requested review from Schweber

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_merger (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superherointj @Schweber @Haskellered @AndersonTorres