-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emacsPackages.tsc: refactor #335438
emacsPackages.tsc: refactor #335438
Conversation
@@ -0,0 +1,285 @@ | |||
# This file is automatically @generated by Cargo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't check lock files into nixpkgs: #327064.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there are git dependencies in Cargo.lock
, we have to do this instead of using cargoHash
.
nixpkgs/pkgs/build-support/rust/fetch-cargo-tarball/default.nix
Lines 79 to 88 in abcef4d
if grep '^source = "git' Cargo.lock; then | |
echo | |
echo "ERROR: The Cargo.lock contains git dependencies" | |
echo | |
echo "This is currently not supported in the fixed-output derivation fetcher." | |
echo "Use cargoLock.lockFile / importCargoLock instead." | |
echo | |
exit 1 | |
fi |
IMHO, #327064 means if there is no git dependency we should always prefer cargoHash
.
pkgs/applications/editors/emacs/elisp-packages/manual-packages/tsc/package.nix
Show resolved
Hide resolved
bc0a894
to
613764e
Compare
- use melpaBuild as the main derivation - use cargoLock due to git deps in Cargo.lock - use nix-update-script as the update script - fix errors in native compilations - rename dynamic module with the help of stdenv.hostPlatform.extensions.sharedLibrary instead of bash magic - remove unneeded rustPlatform.bindgenHook
613764e
to
f7fbcb8
Compare
part of #335442
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.