-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antares: 0.7.24 -> 0.7.28 #335924
antares: 0.7.24 -> 0.7.28 #335924
Conversation
https://github.com/antares-sql/antares/releases/tag/v0.7.25 bumped So I'd suggest updating the package itself to its latest version, at the time of writing https://github.com/antares-sql/antares/releases/tag/v0.7.28, first :) |
Vi, |
this commit in antares is the origin of all my errors : b7dfd5cb8c8e8825311fb49a265c7c492470b13b |
1003ac7
to
816cab7
Compare
There is still a hash mismatch. |
I can't use the patch directly from the PR because the PR is going to be merged in develop branch in antares and not in master. So the patch is not applicable. |
Best to vendor the patch in Nixpkgs in this case. |
ok I will try to do so.
|
My last push, build and works on my pc |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-335924-to-release-24.05 origin/release-24.05
cd .worktree/backport-335924-to-release-24.05
git switch --create backport-335924-to-release-24.05
git cherry-pick -x 5c764c21d8ee0e6a795329a6a6b4927eb0930471 |
Description of changes
Bump antares to 0.7.28 which enables building using electron_30 which is necessary because electron_29 is in EOL.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.