Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: 29.4.5 -> 29.4.6, 30.3.1 -> 30.4.0 #336036

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

yayayayaka
Copy link
Member

Description of changes

Electron 29

This is the last release before reaching end-of-life. Cleanup will be handled in #335850.

Electron 30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 20, 2024
@SuperSandro2000 SuperSandro2000 merged commit fea291c into NixOS:master Aug 22, 2024
30 of 31 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-336036-to-release-24.05 origin/release-24.05
cd .worktree/backport-336036-to-release-24.05
git switch --create backport-336036-to-release-24.05
git cherry-pick -x 0603cf535bbd36e47ec620f4c38a4c15a65dee87 617ca89ef2d3cf29a14777a968a7679ad959a7f8 de2eae76fcdf2bce2139194d8efb660985f6e0a5 a370fc86f6ce7d6bea331c3b720122aca1f31fef 21635ab4311156a70134835317bd948f3b62c9b6 eb6c2470c067c43e50101f70ef74e4d773f00473

@emilazy emilazy mentioned this pull request Aug 27, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants