nix-editor: init at 0.3.0 #340033
Open
nix-editor: init at 0.3.0 #340033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
eclairevoyant
suggested changes
Sep 6, 2024
hsjobeki
force-pushed
the
init/nix-editor
branch
from
595c240 to
b898055
Compare
Thanks for the review. Fiy: No rnix is not dead. It is a pretty good quality rust library. That is used in a lot of tools we use in nixpkgs. |
| hash = "sha256-Ne9NG7x45a8aJyAN+yYWbr/6mQHBVVkwZZ72EZHHRqw="; | ||
| }; | ||
|
|
||
| cargoHash = "sha256-ZWSLW+mFT+Qls2GeVPamispL8ObieXT4tDc1Go5cjL4="; |
There was a problem hiding this comment.
Suggested change
| cargoHash = "sha256-ZWSLW+mFT+Qls2GeVPamispL8ObieXT4tDc1Go5cjL4="; | |
| cargoHash = "sha256-1OErQ+bKKInz7pQQCKW82BGODzbD9EFImBnwbiojJgk="; |
There was a problem hiding this comment.
Or I wonder is this #308089 rearing its head?
There was a problem hiding this comment.
No, I get the same hash mismatch on Linux.
FliegendeWurst
requested changes
Nov 6, 2024
|
|
||
| cargoHash = "sha256-ZWSLW+mFT+Qls2GeVPamispL8ObieXT4tDc1Go5cjL4="; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.Security ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.Security ]; | |
| buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [ darwin.Security ]; |
| hash = "sha256-Ne9NG7x45a8aJyAN+yYWbr/6mQHBVVkwZZ72EZHHRqw="; | ||
| }; | ||
|
|
||
| cargoHash = "sha256-ZWSLW+mFT+Qls2GeVPamispL8ObieXT4tDc1Go5cjL4="; |
There was a problem hiding this comment.
No, I get the same hash mismatch on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A simple rnix-ast based programm to modify NixOS configuration files.
It allows to edit atomic nix values while preserving the overall structure such as formatting and comments.
It has some known bugs but generally works really nice.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.