flutter: roll forward missed patches to v3.23 and v3.24

[phlip9]

Description of changes

This gradle-flutter-tools-wrapper.patch is necessary for android builds using nixpkgs flutter. The patch file is present for prior package versions (3.16, 3.19, 3.22), but it looks like the previous update PR missed it (#336650).

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[phlip9]

cc @RossComputerGuy

[RossComputerGuy]

Sweet, this looks good. CC @NixOS/flutter, we should probably work on improving the patch system so we don't have to copy a bunch of patches. Maybe something similar to getVersionFile which I implemented in LLVM?

[hatch01]

Will it be possible to merge this PR first to be able quickly to build apk using nixpkgs flutter and then look at how to improve the build system?

[kjxbyz]

Does this PR include flutter 3.24.3?

[RossComputerGuy]

Does this PR include flutter 3.24.3?

Yes

[Aleksanaa]

x86_64-linux

3 packages failed to build:
quickgui quickgui.debug quickgui.pubcache

16 packages built:
flet-client-flutter flet-client-flutter.debug flet-client-flutter.pubcache flutter flutter323 flutterPackages-source.beta flutterPackages-source.v3_24 hover python311Packages.flet python311Packages.flet-runtime python311Packages.flet-runtime.dist python311Packages.flet.dist python312Packages.flet python312Packages.flet-runtime python312Packages.flet-runtime.dist python312Packages.flet.dist

quickgui log: https://paste.aleksana.moe/--+Cid

[Aleksanaa]

It's also failing on master: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.quickgui.x86_64-linux

[kjxbyz]

Is flutter 3.24.3 released? No flutter 3.24.3 was found in the search results.

https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=flutter

[RossComputerGuy]

Is flutter 3.24.3 released?

Yes, https://github.com/NixOS/nixpkgs/tree/master/pkgs/development/compilers/flutter/versions

No flutter 3.24.3 was found in the search results.

Likely hasn't rolled through the pipeline fully yet.

[kjxbyz]

Thanks for your reply, how long does it take through the pipeline?

[byronogis]

Thanks for your reply, how long does it take through the pipeline?

unstable already

[kjxbyz]

No flutter 3.24.3 was found in the search results.

https://search.nixos.org/packages?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=flutter

[Lucas-Haux]

How long is it expected to take for 3.24.3 to come out?

[RossComputerGuy]

It should already be out, even if it isn't in the search.