tailscaled: after NetworkManager-wait-online

[supermarin]

Description of changes

Follow up on #180175 - it was suggested to add this to the Tailscale module to fix the problem for 99% users.

Stuff I didn't think about: is NetworkManager-wait-online.service on every nixos installation, and what would happen if it wasn't the case?

Closes #180175

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Atemu]

Please squash the two commits; it's one logical change.

[supermarin]

Done

[NickCao]

Stuff I didn't think about: is NetworkManager-wait-online.service on every nixos installation, and what would happen if it wasn't the case?

Or just use network-online.target

[Atemu]

It's specifically to do with NetworkManager. It should still happen before the network-online.target.

[Atemu]

I think the only good way to test this is to have it land in unstable and thereby hit people's weird systems.

Nobody has been able to repro the issue with this hacked into their config as of yet, so I think this might actually work around the issue.

[supermarin]

FWIW I tried to reproduce the real issue yesterday night without any hacks, and I couldn't (but think because it wasn't restarting network manager on activation).
I think you're safe to merge as is, and I'll try to reproduce before / after in a VM or on a spare box.
If I find that the issue doesn't exist anymore in todays revision of nixpkgs, will report back here and we can revert.

[getchoo]

but think because it wasn't restarting network manager on activation

This does seem to be the root cause. I've experienced it personally as well for probably over a year now (so I'm extremely happy to see this 😄)

[Atemu]

I don't think anyone has been able to reliably reproduce this issue before, it really is something you just need to wait out a few days~a week to trigger.

[fpletz]

I think the only good way to test this is to have it land in unstable and thereby hit people's weird systems.

👍

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] tailscaled: after NetworkManager-wait-online #346647