_1password: modernize; 2.29.0 -> 2.30.0 #350504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
force-pushed
the
1password
branch
2 times, most recently
from
431119b to
fc3b823
Compare
|
|
Packaging changes seems ok for me. I'm not a NixPkgs expert though |
dotlambda
reviewed
Oct 22, 2024
dotlambda
changed the title
ofborg
bot
added
the
11.by: package-maintainer
Scrumplex
approved these changes
Oct 24, 2024
|
@Scrumplex looks like the checks have finished |
13 tasks
19 tasks
wegank
added
the
12.approvals: 1
|
Scrumplex
approved these changes
Oct 26, 2024
|
Thanks for reviewing and merging this, @Scrumplex, very helpful 😃 Was this part of NixCon's Commiter Date? |
I did this one when I was done debugging one of the Committer Date PRs for 3h ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
https://releases.1password.com/developers/cli/#1password-cli-2.30.0
Saw old nixpkgs-update was hung since june on an old version, modernized derivation and bumped version.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.