nixos/uwsm: enable display manager by default #351626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
JohnRTitor
reviewed
Oct 27, 2024
ofborg
bot
added
10.rebuild-darwin: 0
Seems like this is only set to true when actually using a display manager or when enabling |
|
I thought I should upstream this as some friends at NixCon faced this exact issue like I did |
UWSM is not usable if wayland-sessions are not linked. So `services.displayManager.enable` should be true if UWSM is used. `services.graphical-desktop.enable` is implied by `services.displayManager.enable`. See nixos/modules/services/misc/graphical-desktop.nix Signed-off-by: Sefa Eyeoglu <[email protected]>
Scrumplex
force-pushed
the
nixos/uwsm/display-manager
branch
from
00e9311 to
7d43e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UWSM is not usable if wayland-sessions are not linked. So
services.displayManager.enableshould be true if UWSM is used.services.graphical-desktop.enableis implied byservices.displayManager.enable.See nixos/modules/services/misc/graphical-desktop.nix
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.