Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.easy-thumbnails: 2.8.5 -> 2.10.0 #352059

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented Oct 29, 2024

Diff: SmileyChris/easy-thumbnails@2.8.5...2.10.0

Update package, add and fix tests

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 29, 2024
@onny onny requested review from Mic92 and fabaff October 30, 2024 07:09
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 2, 2024
@onny onny requested a review from mweinelt November 2, 2024 12:28
@onny onny changed the title python3Packages.easy-thumbnails: 2.8.5 -> 2.10 python3Packages.easy-thumbnails: 2.8.5 -> 2.10.0 Nov 3, 2024
@onny onny requested a review from mweinelt November 3, 2024 19:46
@onny
Copy link
Contributor Author

onny commented Nov 3, 2024

Thank you @mweinelt fixed it :)

@sarahec
Copy link
Contributor

sarahec commented Nov 4, 2024

Result of nixpkgs-review pr 352059 run on aarch64-darwin 1

4 packages built:
  • python311Packages.easy-thumbnails
  • python311Packages.easy-thumbnails.dist
  • python312Packages.easy-thumbnails
  • python312Packages.easy-thumbnails.dist

@sarahec sarahec added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2024
@onny onny merged commit 6323b54 into NixOS:master Nov 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants