Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fex: init at 2412 #352205

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fex: init at 2412 #352205

merged 1 commit into from
Dec 12, 2024

Conversation

andre4ik3
Copy link
Member

@andre4ik3 andre4ik3 commented Oct 29, 2024

Adds FEX, a fast usermode x86 and x86-64 emulator for Arm64 Linux.

NOTE: When compiling with tests (doCheck = true), FEX requires a kernel with 4k page size. So this means, e.g. running it directly on something like the 16k page size Asahi kernel won't work (it will cause a <jemalloc>: Unsupported system page size error when compiling). So for testing I used an aarch64 virtual machine.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 29, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 30, 2024
@andre4ik3 andre4ik3 marked this pull request as draft October 30, 2024 08:09
@Liamolucko
Copy link
Contributor

I have a derivation for FEX 2408 with working tests over here, if you wanted to use that for reference: https://github.com/Liamolucko/nix-config/blob/31ae4e3240addc81fd79afb4344050619f639813/pkgs/fex/default.nix

@andre4ik3
Copy link
Member Author

Oh, nice! I unfortunately couldn't finish the tests on the day of making the PR and didn't have much time to work on this recently, hence I marked it as draft. But I'll try to integrate the tests now from your branch and see how it goes.

@andre4ik3 andre4ik3 changed the title fex: init at 2410 fex: init at 2412 Dec 10, 2024
@andre4ik3
Copy link
Member Author

I think for now I will not add tests, as they cause build failures on kernels with 16k page size.

@andre4ik3 andre4ik3 marked this pull request as ready for review December 10, 2024 08:01
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 10, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only three minor changes requested

pkgs/by-name/fe/fex/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fe/fex/package.nix Show resolved Hide resolved
pkgs/by-name/fe/fex/package.nix Outdated Show resolved Hide resolved
@andre4ik3
Copy link
Member Author

Done :)

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Dec 11, 2024
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 12, 2024
@Aleksanaa
Copy link
Member

@ofborg build fex

@Aleksanaa Aleksanaa merged commit f3ab2ef into NixOS:master Dec 12, 2024
23 of 25 checks passed
@andre4ik3 andre4ik3 deleted the andre4ik3-fex branch December 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants