-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fex: init at 2412 #352205
fex: init at 2412 #352205
Conversation
I have a derivation for FEX 2408 with working tests over here, if you wanted to use that for reference: https://github.com/Liamolucko/nix-config/blob/31ae4e3240addc81fd79afb4344050619f639813/pkgs/fex/default.nix |
Oh, nice! I unfortunately couldn't finish the tests on the day of making the PR and didn't have much time to work on this recently, hence I marked it as draft. But I'll try to integrate the tests now from your branch and see how it goes. |
727507b
to
095d616
Compare
I think for now I will not add tests, as they cause build failures on kernels with 16k page size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only three minor changes requested
Done :) |
434ac2b
to
7668c64
Compare
7668c64
to
01d6f87
Compare
@ofborg build fex |
Adds FEX, a fast usermode x86 and x86-64 emulator for Arm64 Linux.
NOTE: When compiling with tests (
doCheck = true
), FEX requires a kernel with 4k page size. So this means, e.g. running it directly on something like the 16k page size Asahi kernel won't work (it will cause a<jemalloc>: Unsupported system page size
error when compiling). So for testing I used an aarch64 virtual machine.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.