Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.jupysql: disable broken tests due to duckdb>=1.1.0 #352864

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Nov 1, 2024

Disable a few tests for jupysql seemingly caused by later versions of duckdb (>=1.1.0)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tobim
Copy link
Contributor

tobim commented Nov 2, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352864


x86_64-linux

✅ 4 packages built:
  • python311Packages.jupysql
  • python311Packages.jupysql.dist
  • python312Packages.jupysql
  • python312Packages.jupysql.dist

@tobim tobim added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign and removed 6.topic: python labels Nov 2, 2024
@cpcloud
Copy link
Contributor Author

cpcloud commented Nov 4, 2024

@Aleksanaa Would you mind merging this one too?

@Aleksanaa
Copy link
Member

@ofborg build python311Packages.jupysql python312Packages.jupysql

@cpcloud cpcloud mentioned this pull request Nov 6, 2024
13 tasks
@wegank wegank merged commit 182fa20 into NixOS:master Nov 9, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants