Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.uamqp: 1.6.9 -> 1.6.11 #353152

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

natsukium
Copy link
Member

Diff: Azure/azure-uamqp-python@refs/tags/v1.6.9...v1.6.11

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member Author

natsukium commented Nov 2, 2024

Result of nixpkgs-review pr 353152 at 0d0d64b run on aarch64-darwin 1

✅ 2 packages built:
  • python311Packages.taxi
  • taxi-cli (python312Packages.taxi)

Result of nixpkgs-review pr 353152 at bc511c6 run on x86_64-linux 1

✅ 2 packages built:
  • python311Packages.uamqp
  • python312Packages.uamqp

Result of nixpkgs-review pr 353152 at b8b2bef run on x86_64-darwin 1

✅ 2 packages built:
  • python311Packages.uamqp
  • python312Packages.uamqp

Result of nixpkgs-review pr 353152 at b8b2bef run on aarch64-darwin 1

✅ 2 packages built:
  • python311Packages.uamqp
  • python312Packages.uamqp

@tjni
Copy link
Contributor

tjni commented Nov 3, 2024

Can you try pulling in Azure/azure-uamqp-python#411 and rebuilding? Currently, it fails for me on aarch64-darwin due to Azure/azure-uamqp-python#386.

Comment on lines 30 to 37
patches = lib.optionals (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64) [
./darwin-azure-c-shared-utility-corefoundation.patch
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have x86_64-darwin so can't test, but I wonder if this is still needed even after the Darwin rework. (It sucks that we have to wait for 9-10 hours for an ofborg eval.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the patch as it didn't seem to be needed anymore. Thanks.

@natsukium
Copy link
Member Author

Can you try pulling in Azure/azure-uamqp-python#411 and rebuilding? Currently, it fails for me on aarch64-darwin due to Azure/azure-uamqp-python#386.

I accidentally deleted the patch that was there. Thanks for submitting the PR.

@tjni tjni merged commit 06823bc into NixOS:master Nov 4, 2024
27 of 28 checks passed
@natsukium natsukium deleted the uamqp/update branch November 5, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants