-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.uamqp: 1.6.9 -> 1.6.11 #353152
Conversation
e9e78f9
to
bc511c6
Compare
Result of ✅ 2 packages built:
Result of ✅ 2 packages built:
Result of ✅ 2 packages built:
Result of ✅ 2 packages built:
|
Can you try pulling in Azure/azure-uamqp-python#411 and rebuilding? Currently, it fails for me on aarch64-darwin due to Azure/azure-uamqp-python#386. |
patches = lib.optionals (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isx86_64) [ | ||
./darwin-azure-c-shared-utility-corefoundation.patch | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have x86_64-darwin so can't test, but I wonder if this is still needed even after the Darwin rework. (It sucks that we have to wait for 9-10 hours for an ofborg eval.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the patch as it didn't seem to be needed anymore. Thanks.
bc511c6
to
b8b2bef
Compare
I accidentally deleted the patch that was there. Thanks for submitting the PR. |
Diff: Azure/azure-uamqp-python@refs/tags/v1.6.9...v1.6.11
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.